Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64887

Update bootstrap to version 4.3.1

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.8
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Use 2 Moodle instances, one based on the integration branch including this patch, one on latests master. In both instances take these steps:

      1. Login as Admin
      2. Create a course C1
      3. Restore the attached backup to course C1
      4. Compare the restored book page by page with the other Moodle instance
      5. Verify the book content looks the same on both instances
      6. Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Please note Tooltips are not functional.

       

      Check if there are no sass parse errors in your apache logs

      1. Login as Admin
      2. Navigate to Site Administration -> Development -> Debugging
      3. Choose Developer.. at Debug messages
      4. Tick the Display debug messages checkbox
      5. Open a console showing your web server / php log files
      6. Navigate to Site Administration -> Development -> Purge Caches
      7. Navigate to the Site Homepage
      8. Wait for the page to load and rebuild caches
      9. Check the log file for errors

      Test if the CSS compiled correctly after the hack for badges were removed (MDL-65761)

      1. Login as Admin
      2. Navigate to the restored Book activity
      3. On page 2, Badges, hover over the badges after "Test for badge hover status"
      4. Verfiy you do not see a link underline when hovering over the badges.
      Show
      Use 2 Moodle instances, one based on the integration branch including this patch, one on latests master. In both instances take these steps: Login as Admin Create a course C1 Restore the attached backup to course C1 Compare the restored book page by page with the other Moodle instance Verify  the book content looks the same on both instances Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Please note Tooltips are not functional.   Check if there are no sass parse errors in your apache logs Login as Admin Navigate to Site Administration -> Development -> Debugging Choose Developer.. at Debug messages Tick the Display debug messages checkbox Open a console showing your web server / php log files Navigate to Site Administration -> Development -> Purge Caches Navigate to the Site Homepage Wait for the page to load and rebuild caches Check the log file for errors Test if the CSS compiled correctly after the hack for badges were removed ( MDL-65761 ) Login as Admin Navigate to the restored Book activity On page 2, Badges, hover over the badges after "Test for badge hover status" Verfiy you do not see a link underline when hovering over the badges.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64887-master-3
    • Story Points:
      1
    • Sprint:
      Moppies Moodle 3.8 Sprint 1, Moppies Moodle 3.8 Sprint 2, Moppies Moodle 3.8 Sprint 3, Moppies Moodle 3.8 Sprint 4

      Description

      Update the Bootstrap JS and SASS to version 4.3.1

        Attachments

        1. backup-moodle2-activity-101-book101-20190715-1718-nu.mbz
          8 kB
          Bas Brands
        2. Screenshot_1.png
          339 kB
          Janelle Barcega
        3. Screenshot_2.png
          508 kB
          Janelle Barcega
        4. Screenshot_3.png
          140 kB
          Janelle Barcega
        5. Screenshot_4.png
          219 kB
          Janelle Barcega
        6. Screenshot_5.png
          90 kB
          Janelle Barcega
        7. View-gradebook-when-scales-are-used_I-navigate-to-Edit-settings-in-current-page-administration_49.png
          149 kB
          Eloy Lafuente (stronk7)

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 5 hours, 5 minutes
                  2d 5h 5m