Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64906

Use hideif for Moodle forms in the mod/ directory

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Choice activity
      1. Visit a course and turn editing on
      2. Add a choice activity
      3. On the settings form:
      4. Set 'Limit the number of responses' to 'No' (the default)
      5. Confirm the 'Limit 1', 'Limit 2', etc. fields are not shown
      6. Set 'Limit the number of responses' to 'Yes'
      7. Confirm the 'Limit 1', 'Limit 2', etc. fields are shown
      8. Set 'Publish results' to 'Do not publish results to students' (the default)
      9. Confirm 'Privacy of results' is not shown
      10. Set 'Publish results' to each of the other values
      11. Confirm 'Privacy of results' is shown
      Database activity
      1. Visit a course and turn editing on
      2. Add a database activity
      3. On the settings form:
      4. Set 'Approval required' to 'No' (the default)
      5. Confirm 'Allow editing of approved entries' is not shown
      6. Set 'Approval required' to 'Yes'
      7. Confirm 'Allow editing of approved entries' is shown
      Feedback activity
      1. Visit a course and turn editing on
      2. Add a feedback activity
      3. Visit the 'Edit questions' tab
      4. Add a 'Multiple choice' question
      5. Set 'Multiple choice type' to 'Multiple choice - single answer' (the default)
      6. Confirm 'Adjustment' and 'Hide the "Not selected" option' are shown
      7. Set 'Multiple choice type' to 'Multiple choice - multiple answers'
      8. Confirm 'Adjustment' is shown
      9. Confirm 'Hide the "Not selected" option' is not shown
      10. Set 'Multiple choice type' to 'Multiple choice - single answer allowed (dropdownlist)'
      11. Confirm 'Adjustment' and 'Hide the "Not selected" option' are not shown
      12. Save the question
      13. Add a 'Multiple choice (rated)' question
      14. Set 'Multiple choice type' to 'Multiple choice - single answer' (the default)
      15. Confirm 'Adjustment' and 'Hide the "Not selected" option' are shown
      16. Set 'Multiple choice type' to 'Multiple choice - single answer allowed (dropdownlist)'
      17. Confirm 'Adjustment' and 'Hide the "Not selected" option' are not shown
      18. Set 'Dependence item' to 'Choose' (the default)
      19. Confirm 'Dependence value' is not shown
      20. Set 'Dependence item' to the name of the other question you created
      21. Confirm 'Dependence value' is shown
      Forum activity
      1. Enable RSS feeds at: Site admin > Advanced features > Enable RSS feeds
      2. Enable forum RSS feeds at: Site admin > Plugins > Activity modules > Forum > Enable RSS feeds
      3. Visit a course and turn editing on
      4. Add a forum activity
      5. On the settings form:
      6. Set 'RSS feed for this activity' to 'None' (the default)
      7. Confirm 'Number of RSS recent articles' is not shown
      8. Set 'RSS feed for this activity' to 'Discussions' or 'Posts'
      9. Confirm 'Number of RSS recent articles' is shown
      10. Set 'Time period for blocking' to 'Don't block' (the default)
      11. Confirm 'Post threshold for blocking' and 'Post threshold for warning' are not shown
      12. Set 'Time period for blocking' to any other value
      13. Confirm 'Post threshold for blocking' and 'Post threshold for warning' are shown
      Glossary activity
      1. Enable RSS feeds at: Site admin > Advanced features > Enable RSS feeds
      2. Enable glossary RSS feeds at: Site admin > Plugins > Activity modules > Glossary > Enable RSS feeds
      3. Visit a course and turn editing on
      4. Add a glossary activity
      5. On the settings form:
      6. Set 'RSS feed for this activity' to 'None' (the default)
      7. Confirm 'Number of RSS recent articles' is not shown
      8. Set 'RSS feed for this activity' to 'Concepts with author' or 'Concepts without author'
      9. Confirm 'Number of RSS recent articles' is shown
      10. After saving the glossary, click 'Add entry'
      11. Set 'This entry should be automatically linked' to unchecked (the default)
      12. Confirm 'This entry is case sensitive' and 'Match whole words only' are not shown
      13. Set 'This entry should be automatically linked' to checked
      14. Confirm 'This entry is case sensitive' and 'Match whole words only' are shown
      Lesson activity
      1. Visit a course and turn editing on
      2. Add a lesson activity
      3. On the settings form:
      4. Click 'Show more ...', under 'Availability'
      5. Set 'Password protected lesson' to 'No' (the default)
      6. Confirm 'Password' is not shown
      7. Set 'Password protected lesson' to 'Yes'
      8. Confirm 'Password' is shown
      9. Click 'Show more ...', under 'Grade'
      10. Set 'Re-takes allowed' to 'No' (the default)
      11. Confirm 'Handling of re-takes' is not shown
      12. Set 'Re-takes allowed' to 'Yes'
      13. Confirm 'Handling of re-takes' is shown
      External tool activity
      1. Create a global tool under Site admin > Plugins > Activity modules > External tool > Manage tools
      2. Call the tool 'Global tool 1'
      3. The URL can be set to www.example.com + the rest of the settings left blank
      4. Visit a course and turn editing on
      5. Add an external tool activity
      6. On the settings form:
      7. Click 'Show more ...', under 'General'
      8. Set 'Preconfigured tool' to 'Automatic, based on tool URL'
      9. Confirm the following are all shown: 'Tool URL', 'Secure tool URL', 'Consumer key', 'Shared secret', 'Icon URL', 'Secure icon URL'
      10. Set 'Preconfigured tool' to 'Global tool 1'
      11. Confirm the following are not shown: 'Tool URL', 'Secure tool URL', 'Consumer key', 'Shared secret', 'Icon URL', 'Secure icon URL'
      Page resource
      1. Add 'Open' (selected by default) and 'In pop-up' to the 'available display options' on Site admin > Plugins > Activity modules > Page
      2. Visit a course and turn editing on
      3. Add a page resource
      4. On the settings form:
      5. Set 'Display' to 'Open' (the default)
      6. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown
      7. Set 'Display' to 'In pop-up'
      8. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are shown
      Quiz activity
      1. Visit a course and turn editing on
      2. Add a quiz activity
      3. On the settings form:
      4. Set 'When time expires' to 'Open attempts are submitted automatically' (the default)
      5. Confirm 'Submission grace period' is not shown
      6. Set 'When time expires' to 'There is a grace period ...'
      7. Confirm 'Submission grace period' is shown
      8. Set 'Attempts allowed' to '1':
      9. Confirm 'Grading method', 'Each attempt builds on the last', 'Enforced delay between 1st and 2nd attempts' and 'Enforced delay between later attempts' are not shown
      10. Set 'Attempts allowed' to '2':
      11. Confirm 'Grading method', 'Each attempt builds on the last' and 'Enforced delay between 1st and 2nd attempts' are shown
      12. Confirm 'Enforced delay between later attempts' is not shown
      13. Set 'Attempts allowed' to '3':
      14. Confirm 'Grading method', 'Each attempt builds on the last', 'Enforced delay between 1st and 2nd attempts' and 'Enforced delay between later attempts' are shown
      15. Set 'How questions behave' to 'Deferred feedback' (the default)
      16. Confirm 'Allow redo within an attempt' is not shown
      17. Set 'How questions behave' to 'Immediate feedback'
      18. Confirm 'Allow redo within an attempt' is shown
      File resource
      1. Visit a course and turn editing on
      2. Add a file resource
      3. On the settings form:
      4. Set 'Display' to 'Automatic' (the default)
      5. Confirm 'Display resource description' is shown
      6. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown
      7. Set 'Display' to 'Force download'
      8. Confirm 'Display resource description' is not shown
      9. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown
      10. Set 'Display' to 'In pop-up'
      11. Confirm 'Display resource description' is not shown
      12. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are shown
      SCORM package
      1. Visit Site admin > Plugins > Activity modules > SCORM package
      2. Enable 'allowtypeexternal' and 'allowtypeexternalaicc'
      3. Visit a course and turn editing on
      4. Add a SCORM package
      5. On the settings form:
      6. Set 'Type' to 'Uploaded package' (the default)
      7. Confirm 'Package file' is shown
      8. Confirm 'URL' is not shown
      9. Set 'Type' to 'External SCORM manifest'
      10. Confirm 'Package file' is not shown
      11. Confirm 'URL' is shown
      12. Set 'Display package' to 'Current window' (the default)
      13. Confirm 'Width', 'Height', 'Options (prevented by some browsers)' are not shown
      14. Set 'Display package' to 'New window'
      15. Confirm 'Width', 'Height', 'Options (prevented by some browsers)' are shown
      16. Set 'Display course structure in player' to 'To the side' (the default)
      17. Confirm 'Show navigation' is shown
      18. Set 'Display course structure in player' to 'Hidden'
      19. Confirm 'Show navigation' is not shown
      20. Set 'Display course structure in player' back to 'To the side'
      21. Set 'Show navigation' to 'Under content' (the default)
      22. Confirm 'From left' and 'From top' are not shown
      23. Set 'Show navigation' to 'Floating'
      24. Confirm 'From left' and 'From top' are shown
      25. Set 'Grading method' to 'Highest grade' (the default)
      26. Confirm 'Maximum grade' is shown
      27. Set 'Grading method' to 'Learning objects'
      28. Confirm 'Maximum grade' is not shown
      29. Set 'Number of attempts' to 'Unlimited' (the default)
      30. Confirm 'Attempts grading' is shown
      31. Set 'Number of attempts' to '1'
      32. Confirm 'Attempts grading' is not shown
      URL resource
      1. Visit a course and turn editing on
      2. Add a URL resource
      3. On the settings form:
      4. Set 'Display' to 'Automatic' (the default)
      5. Confirm 'Display URL description' is shown
      6. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown
      7. Set 'Display' to 'Open'
      8. Confirm 'Display URL description' is not shown
      9. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown
      10. Set 'Display' to 'In pop-up'
      11. Confirm 'Display URL description' is not shown
      12. Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are shown
      Workshop module
      1. Visit a course and turn editing on
      2. Add a Workshop activity
      3. On the settings form:
      4. Set 'File attachment' to 'Enabled' (the default)
      5. Confirm 'Maximum number of submission attachments', 'Submission attachment allowed file types' and 'Maximum submission attachment size' are shown
      6. Set 'File attachment' to 'Disabled'
      7. Confirm 'Maximum number of submission attachments', 'Submission attachment allowed file types' and 'Maximum submission attachment size' are not shown
      8. Set 'Overall feedback mode' to 'Enabled and optional' (the default)
      9. Confirm 'Maximum number of overall feedback attachments' is shown
      10. Set 'Overall feedback mode' to 'Disabled'
      11. Confirm 'Maximum number of overall feedback attachments' is not shown
      12. Set 'Overall feedback mode' back to 'Enabled and optional'
      13. Set 'Maximum number of overall feedback attachments' to '0' (the default)
      14. Confirm 'Feedback attachment allowed file types' and 'Maximum overall feedback attachment size' are not shown
      15. Set 'Maximum number of overall feedback attachments' to '1'
      16. Confirm 'Feedback attachment allowed file types' and 'Maximum overall feedback attachment size' are shown
      17. Set 'Use examples' to 'Disabled' (the default)
      18. Confirm 'Mode of examples assessment' is not shown
      19. Set 'Use examples' to 'Enabled'
      20. Confirm 'Mode of examples assessment' is shown
      21. Set 'Submissions deadline' to 'Disabled' (the default)
      22. Confirm 'Switch to the next phase after submissions deadline' is not shown
      23. Set 'Submissions deadline' to 'Enabled'
      24. Confirm 'Switch to the next phase after submissions deadline' is shown
      Show
      Choice activity Visit a course and turn editing on Add a choice activity On the settings form: Set 'Limit the number of responses' to 'No' (the default) Confirm the 'Limit 1', 'Limit 2', etc. fields are not shown Set 'Limit the number of responses' to 'Yes' Confirm the 'Limit 1', 'Limit 2', etc. fields are shown Set 'Publish results' to 'Do not publish results to students' (the default) Confirm 'Privacy of results' is not shown Set 'Publish results' to each of the other values Confirm 'Privacy of results' is shown Database activity Visit a course and turn editing on Add a database activity On the settings form: Set 'Approval required' to 'No' (the default) Confirm 'Allow editing of approved entries' is not shown Set 'Approval required' to 'Yes' Confirm 'Allow editing of approved entries' is shown Feedback activity Visit a course and turn editing on Add a feedback activity Visit the 'Edit questions' tab Add a 'Multiple choice' question Set 'Multiple choice type' to 'Multiple choice - single answer' (the default) Confirm 'Adjustment' and 'Hide the "Not selected" option' are shown Set 'Multiple choice type' to 'Multiple choice - multiple answers' Confirm 'Adjustment' is shown Confirm 'Hide the "Not selected" option' is not shown Set 'Multiple choice type' to 'Multiple choice - single answer allowed (dropdownlist)' Confirm 'Adjustment' and 'Hide the "Not selected" option' are not shown Save the question Add a 'Multiple choice (rated)' question Set 'Multiple choice type' to 'Multiple choice - single answer' (the default) Confirm 'Adjustment' and 'Hide the "Not selected" option' are shown Set 'Multiple choice type' to 'Multiple choice - single answer allowed (dropdownlist)' Confirm 'Adjustment' and 'Hide the "Not selected" option' are not shown Set 'Dependence item' to 'Choose' (the default) Confirm 'Dependence value' is not shown Set 'Dependence item' to the name of the other question you created Confirm 'Dependence value' is shown Forum activity Enable RSS feeds at: Site admin > Advanced features > Enable RSS feeds Enable forum RSS feeds at: Site admin > Plugins > Activity modules > Forum > Enable RSS feeds Visit a course and turn editing on Add a forum activity On the settings form: Set 'RSS feed for this activity' to 'None' (the default) Confirm 'Number of RSS recent articles' is not shown Set 'RSS feed for this activity' to 'Discussions' or 'Posts' Confirm 'Number of RSS recent articles' is shown Set 'Time period for blocking' to 'Don't block' (the default) Confirm 'Post threshold for blocking' and 'Post threshold for warning' are not shown Set 'Time period for blocking' to any other value Confirm 'Post threshold for blocking' and 'Post threshold for warning' are shown Glossary activity Enable RSS feeds at: Site admin > Advanced features > Enable RSS feeds Enable glossary RSS feeds at: Site admin > Plugins > Activity modules > Glossary > Enable RSS feeds Visit a course and turn editing on Add a glossary activity On the settings form: Set 'RSS feed for this activity' to 'None' (the default) Confirm 'Number of RSS recent articles' is not shown Set 'RSS feed for this activity' to 'Concepts with author' or 'Concepts without author' Confirm 'Number of RSS recent articles' is shown After saving the glossary, click 'Add entry' Set 'This entry should be automatically linked' to unchecked (the default) Confirm 'This entry is case sensitive' and 'Match whole words only' are not shown Set 'This entry should be automatically linked' to checked Confirm 'This entry is case sensitive' and 'Match whole words only' are shown Lesson activity Visit a course and turn editing on Add a lesson activity On the settings form: Click 'Show more ...', under 'Availability' Set 'Password protected lesson' to 'No' (the default) Confirm 'Password' is not shown Set 'Password protected lesson' to 'Yes' Confirm 'Password' is shown Click 'Show more ...', under 'Grade' Set 'Re-takes allowed' to 'No' (the default) Confirm 'Handling of re-takes' is not shown Set 'Re-takes allowed' to 'Yes' Confirm 'Handling of re-takes' is shown External tool activity Create a global tool under Site admin > Plugins > Activity modules > External tool > Manage tools Call the tool 'Global tool 1' The URL can be set to www.example.com + the rest of the settings left blank Visit a course and turn editing on Add an external tool activity On the settings form: Click 'Show more ...', under 'General' Set 'Preconfigured tool' to 'Automatic, based on tool URL' Confirm the following are all shown: 'Tool URL', 'Secure tool URL', 'Consumer key', 'Shared secret', 'Icon URL', 'Secure icon URL' Set 'Preconfigured tool' to 'Global tool 1' Confirm the following are not shown: 'Tool URL', 'Secure tool URL', 'Consumer key', 'Shared secret', 'Icon URL', 'Secure icon URL' Page resource Add 'Open' (selected by default) and 'In pop-up' to the 'available display options' on Site admin > Plugins > Activity modules > Page Visit a course and turn editing on Add a page resource On the settings form: Set 'Display' to 'Open' (the default) Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown Set 'Display' to 'In pop-up' Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are shown Quiz activity Visit a course and turn editing on Add a quiz activity On the settings form: Set 'When time expires' to 'Open attempts are submitted automatically' (the default) Confirm 'Submission grace period' is not shown Set 'When time expires' to 'There is a grace period ...' Confirm 'Submission grace period' is shown Set 'Attempts allowed' to '1': Confirm 'Grading method', 'Each attempt builds on the last', 'Enforced delay between 1st and 2nd attempts' and 'Enforced delay between later attempts' are not shown Set 'Attempts allowed' to '2': Confirm 'Grading method', 'Each attempt builds on the last' and 'Enforced delay between 1st and 2nd attempts' are shown Confirm 'Enforced delay between later attempts' is not shown Set 'Attempts allowed' to '3': Confirm 'Grading method', 'Each attempt builds on the last', 'Enforced delay between 1st and 2nd attempts' and 'Enforced delay between later attempts' are shown Set 'How questions behave' to 'Deferred feedback' (the default) Confirm 'Allow redo within an attempt' is not shown Set 'How questions behave' to 'Immediate feedback' Confirm 'Allow redo within an attempt' is shown File resource Visit a course and turn editing on Add a file resource On the settings form: Set 'Display' to 'Automatic' (the default) Confirm 'Display resource description' is shown Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown Set 'Display' to 'Force download' Confirm 'Display resource description' is not shown Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown Set 'Display' to 'In pop-up' Confirm 'Display resource description' is not shown Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are shown SCORM package Visit Site admin > Plugins > Activity modules > SCORM package Enable 'allowtypeexternal' and 'allowtypeexternalaicc' Visit a course and turn editing on Add a SCORM package On the settings form: Set 'Type' to 'Uploaded package' (the default) Confirm 'Package file' is shown Confirm 'URL' is not shown Set 'Type' to 'External SCORM manifest' Confirm 'Package file' is not shown Confirm 'URL' is shown Set 'Display package' to 'Current window' (the default) Confirm 'Width', 'Height', 'Options (prevented by some browsers)' are not shown Set 'Display package' to 'New window' Confirm 'Width', 'Height', 'Options (prevented by some browsers)' are shown Set 'Display course structure in player' to 'To the side' (the default) Confirm 'Show navigation' is shown Set 'Display course structure in player' to 'Hidden' Confirm 'Show navigation' is not shown Set 'Display course structure in player' back to 'To the side' Set 'Show navigation' to 'Under content' (the default) Confirm 'From left' and 'From top' are not shown Set 'Show navigation' to 'Floating' Confirm 'From left' and 'From top' are shown Set 'Grading method' to 'Highest grade' (the default) Confirm 'Maximum grade' is shown Set 'Grading method' to 'Learning objects' Confirm 'Maximum grade' is not shown Set 'Number of attempts' to 'Unlimited' (the default) Confirm 'Attempts grading' is shown Set 'Number of attempts' to '1' Confirm 'Attempts grading' is not shown URL resource Visit a course and turn editing on Add a URL resource On the settings form: Set 'Display' to 'Automatic' (the default) Confirm 'Display URL description' is shown Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown Set 'Display' to 'Open' Confirm 'Display URL description' is not shown Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are not shown Set 'Display' to 'In pop-up' Confirm 'Display URL description' is not shown Confirm 'Pop-up width (in pixels)' and 'Pop-up height (in pixels)' are shown Workshop module Visit a course and turn editing on Add a Workshop activity On the settings form: Set 'File attachment' to 'Enabled' (the default) Confirm 'Maximum number of submission attachments', 'Submission attachment allowed file types' and 'Maximum submission attachment size' are shown Set 'File attachment' to 'Disabled' Confirm 'Maximum number of submission attachments', 'Submission attachment allowed file types' and 'Maximum submission attachment size' are not shown Set 'Overall feedback mode' to 'Enabled and optional' (the default) Confirm 'Maximum number of overall feedback attachments' is shown Set 'Overall feedback mode' to 'Disabled' Confirm 'Maximum number of overall feedback attachments' is not shown Set 'Overall feedback mode' back to 'Enabled and optional' Set 'Maximum number of overall feedback attachments' to '0' (the default) Confirm 'Feedback attachment allowed file types' and 'Maximum overall feedback attachment size' are not shown Set 'Maximum number of overall feedback attachments' to '1' Confirm 'Feedback attachment allowed file types' and 'Maximum overall feedback attachment size' are shown Set 'Use examples' to 'Disabled' (the default) Confirm 'Mode of examples assessment' is not shown Set 'Use examples' to 'Enabled' Confirm 'Mode of examples assessment' is shown Set 'Submissions deadline' to 'Disabled' (the default) Confirm 'Switch to the next phase after submissions deadline' is not shown Set 'Submissions deadline' to 'Enabled' Confirm 'Switch to the next phase after submissions deadline' is shown
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-64906_hideif_mod

      Description

      Review all uses of disabledIf in the mod/ directory and switch the appropriate ones to use hideIf instead.

      Screenshots (before and after) of all affected forms can be found in: mod - hideif.pdf

        Attachments

        1. MDL-64906.jpg
          MDL-64906.jpg
          47 kB
        2. MDL-64906 (2).jpg
          MDL-64906 (2).jpg
          38 kB
        3. MDL-64906 (3).jpg
          MDL-64906 (3).jpg
          42 kB
        4. MDL-64906 (4).jpg
          MDL-64906 (4).jpg
          37 kB
        5. MDL-64906 (5).jpg
          MDL-64906 (5).jpg
          56 kB
        6. MDL-64906 (6).jpg
          MDL-64906 (6).jpg
          16 kB
        7. MDL-64906 (7).jpg
          MDL-64906 (7).jpg
          56 kB
        8. MDL-64906 (8).jpg
          MDL-64906 (8).jpg
          56 kB
        9. mod - hideif.pdf
          1.82 MB

          Activity

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours
                7h