Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64917

editor_tinymce: fix error when uploading alternative images

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Set tinymce as preferred  editor by moving it to the top of the list and enabling it (Site admin -> Plugins -> Text editors -> Manage Editors)
      2. Now, in a course, edit a course section
      3. Insert an image
      4. On the advanced tab, check on "Alternative image"
      5. Click to upload "for mouse over" or "for mouse out"
      6. Choose a file and click upload ( If there is another file with the same name, the File Exists dialogue appears, click on "rename to ..." ) but do not proceed to close the Tiny MCE window.
      7. Verify:
        • The file upload completes without error and you see the Tiny MCE 'insert/edit image' window.
        • The image file name is displayed in either the "for mouse over" or "for mouse out" input, depending on which one you selected.
      8. Click insert and confirm the image is added to the section.
      Show
      Set tinymce as preferred  editor by moving it to the top of the list and enabling it (Site admin -> Plugins -> Text editors -> Manage Editors) Now, in a course, edit a course section Insert an image On the advanced tab, check on "Alternative image" Click to upload "for mouse over" or "for mouse out" Choose a file and click upload ( If there is another file with the same name, the File Exists dialogue appears, click on "rename to ..." ) but do not proceed to close the Tiny MCE window. Verify : The file upload completes without error and you see the Tiny MCE 'insert/edit image' window. The image file name is displayed in either the "for mouse over" or "for mouse out" input, depending on which one you selected. Click insert and confirm the image is added to the section.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.6 Branch:
      MDL-64917-MOODLE_36_STABLE
    • Pull 3.7 Branch:
      MDL-64917-MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-64917-Master

      Description

      Javascript error:  Uncaught TypeError: scope.options.editor_target.onchange is not a function

       

      Replication:

      • Set tinymce as preferred  editor
      • Edit a course section
      • Insert an Image
      • On the advanced tab, check on "Alternative image"
      • Click to upload "for mouse over" or "for mouse out"
      • Choose a file and click upload
      • ( If there is another file with the same name, the File Exists dialogue appears, click on "rename to ..." )
      • The error occurs

       

      Reason: there is no "onclick" property for "onmouseoversrc" and "onmouseoutsrc"

       

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 20 minutes
                1h 20m