Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64948

Assignment grading panel uses embedded layout (and shouldn't)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.4, 3.6.2, 3.7
    • Fix Version/s: None
    • Component/s: Assignment, Themes
    • Labels:
      None
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE

      Description

      As Tim Hunt has pointed out in MDL-64591, the assignment grading panel makes use of the Embedded layout. The embedded layout is intended for iframes.

      If the assign grading page is currently claiming to be an 'embedded' layout, then it is cheating. The embedded layout is documented as being for things in iframes. I know what the assign grading page is trying to do, but using embedded layout to achieve it is definitely a hack.

      We need to look at what our options here, but they potentially include:

      1. use a different layout
      2. create a new layout for this kind of interface
      3. update the documentation to state that the embedded layout may be used for fullscreen interfaces

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                dobedobedoh Andrew Nicols
                Participants:
                Component watchers:
                Damyon Wiese, Adrian Greeve, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: