Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64974

Add missing moodle/badges:configurecriteria capability to badges/index.php

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.5.6, 3.6.4
    • 3.5.4, 3.6, 3.7
    • Badges
    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • MDL-64974-master
    • Hide

      Setup

      1. Login as admin.
      2. Access to "Site administration > Users > Permissions > Define roles" and edit the "Editing teacher" role.
      3. Disabled the following capabilities: 
        • moodle/badges:awardbadge
        • moodle/badges:configuredetails
        • moodle/badges:configuremessages
        • moodle/badges:createbadge
        • moodle/badges:deletebadge
        • moodle/badges:viewawarded
      4. Create teacher1.
      5. Create a course (Course 1) and enrol teacher1 as editingteacher.

      Testing instructions

      1. Login as teacher1
      2. Access to the course "Course 1".
      3. On the course cog, click over the "More ..." option.
      4. Click over "Manage badges" link
      5. CHECK that the "Course 1: Manage badges" page is displayed instead of being redirected to home page.

       

      Show
      Setup Login as admin. Access to "Site administration > Users > Permissions > Define roles" and edit the "Editing teacher" role. Disabled the following capabilities:  moodle/badges:awardbadge moodle/badges:configuredetails moodle/badges:configuremessages moodle/badges:createbadge moodle/badges:deletebadge moodle/badges:viewawarded Create teacher1. Create a course (Course 1) and enrol teacher1 as editingteacher. Testing instructions Login as teacher1 Access to the course "Course 1". On the course cog, click over the "More ..." option. Click over "Manage badges" link CHECK that the "Course 1: Manage badges" page is displayed instead of being redirected to home page.  

      While integrating MDL-62631, Eloy has raised that the badges/index.php has a missing capability check: moodle/badges:configurecriteria. This issue only affects users having this capability (moodle/badges:configurecriteria) and not having any other of the 6, which is a weird case.

            sarjona Sara Arjona (@sarjona)
            sarjona Sara Arjona (@sarjona)
            Damyon Wiese Damyon Wiese
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 27 minutes
                27m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.