Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64974

Add missing moodle/badges:configurecriteria capability to badges/index.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.4, 3.6, 3.7
    • Fix Version/s: 3.5.6, 3.6.4
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Login as admin.
      2. Access to "Site administration > Users > Permissions > Define roles" and edit the "Editing teacher" role.
      3. Disabled the following capabilities: 
        • moodle/badges:awardbadge
        • moodle/badges:configuredetails
        • moodle/badges:configuremessages
        • moodle/badges:createbadge
        • moodle/badges:deletebadge
        • moodle/badges:viewawarded
      4. Create teacher1.
      5. Create a course (Course 1) and enrol teacher1 as editingteacher.

      Testing instructions

      1. Login as teacher1
      2. Access to the course "Course 1".
      3. On the course cog, click over the "More ..." option.
      4. Click over "Manage badges" link
      5. CHECK that the "Course 1: Manage badges" page is displayed instead of being redirected to home page.

       

      Show
      Setup Login as admin. Access to "Site administration > Users > Permissions > Define roles" and edit the "Editing teacher" role. Disabled the following capabilities:  moodle/badges:awardbadge moodle/badges:configuredetails moodle/badges:configuremessages moodle/badges:createbadge moodle/badges:deletebadge moodle/badges:viewawarded Create teacher1. Create a course (Course 1) and enrol teacher1 as editingteacher. Testing instructions Login as teacher1 Access to the course "Course 1". On the course cog, click over the "More ..." option. Click over "Manage badges" link CHECK that the "Course 1: Manage badges" page is displayed instead of being redirected to home page.  
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull Master Branch:
      MDL-64974-master
    • Pull Master Diff URL:

      Description

      While integrating MDL-62631, Eloy has raised that the badges/index.php has a missing capability check: moodle/badges:configurecriteria. This issue only affects users having this capability (moodle/badges:configurecriteria) and not having any other of the 6, which is a weird case.

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-62631 UX: Add a link to "Add a new badge" on Badges page

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 27 minutes
                  27m