Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64990

Messaging user tour plays even if messaging is disabled.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.2, 3.7
    • Fix Version/s: 3.6.4
    • Component/s: Messages, User Tours
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. git checkout 4d3a32dde97e964ad4 and install new site.
      2. Create a course.
      3. Create a student user enrolled in the course.
      4. Go to Admin -> Advanced features and turn off the 'Messaging system' option.
      5. Upgrade to latest Moodle 3.6.
      6. Log in as the student and go to the course.
      7. Ensure the user tour for messaging does not play, since it is not relevant.
      Test 2
      1. git checkout a713ed3ba684e3e2 and install new site.
      2. Create a course.
      3. Create a student user enrolled in the course.
      4. Go to Admin -> Advanced features and turn off the 'Messaging system' option.
      5. Upgrade to latest master.
      6. Log in as the student and go to the course.
      7. Ensure the user tour for messaging does not play, since it is not relevant.
      Test 3 (with messaging enabled)
      1. git checkout a713ed3ba684e3e2 and install new site.
      2. Create a course.
      3. Create a student user enrolled in the course.
      4. Go to Admin -> Advanced features and turn on the 'Messaging system' option.
      5. Upgrade to latest master.
      6. Log in as the student and go to the course.
      7. Ensure the user tour for messaging does play, because messaging is enabled.
      Show
      Test 1 git checkout 4d3a32dde97e964ad4 and install new site. Create a course. Create a student user enrolled in the course. Go to Admin -> Advanced features and turn off the 'Messaging system' option. Upgrade to latest Moodle 3.6. Log in as the student and go to the course. Ensure the user tour for messaging does not play, since it is not relevant. Test 2 git checkout a713ed3ba684e3e2 and install new site. Create a course. Create a student user enrolled in the course. Go to Admin -> Advanced features and turn off the 'Messaging system' option. Upgrade to latest master. Log in as the student and go to the course. Ensure the user tour for messaging does not play, since it is not relevant. Test 3 (with messaging enabled) git checkout a713ed3ba684e3e2 and install new site. Create a course. Create a student user enrolled in the course. Go to Admin -> Advanced features and turn on the 'Messaging system' option. Upgrade to latest master. Log in as the student and go to the course. Ensure the user tour for messaging does play, because messaging is enabled.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-64990_master
    • Pull Master Diff URL:

      Description

      Steps to reproduce:

      • Install a new Moodle 3.6.x site.
      • Create a course.
      • Create a student user enrolled in the course.
      • Go to Admin -> Advanced featuers and turn off the 'Messaging system' option.
      • Log in as the student and go to the course.

      Expected result: the user tour does not play, since it is not relevant.
      Actual result: you see the "New messaging system" user tour.

        Attachments

          Issue Links

          has a non-specific relationship to

          New Feature - A new Moodle feature which has yet to be developed. MDL-65111 Multiple calls to update_shipped_tours() in upgrade. Ways to avoid that.

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-64000 User tours for messaging and Dashboard

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 40 minutes
                  1h 40m