Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64998

Remove PHP Less compiler

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.8
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      Test
      1. Download [^test_build_themes.php] to your moodle root directory.
      2. Run it:

        php test_build_themes.php

      3. Run the task "core\task\build_installed_themes_task" master

        php admin/tool/task/cli/adhoc_task.php --execute="\core\task\build_installed_themes_task"
        

      4. Confirm the task ends successfully.
      5. Confirm you don't get any PHP Warning message.
      Show
      Test Download [^test_build_themes.php] to your moodle root directory. Run it: php test_build_themes.php Run the task " core\task\build_installed_themes_task " master php admin/tool/task/cli/adhoc_task.php --execute="\core\task\build_installed_themes_task" Confirm the task ends successfully. Confirm you don't get any PHP Warning message.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
    • Sprint:
      Internationals - 3.8 Sprint 1

      Description

      With MDL-64506 removing all core themes that use the lessphpc in theme designer mode, we will have a library that is no longer required within Moodle core. 

      There are currently two calls to this library located:

      lib/outputlib.php
      get_css_content()
      get_css_content_debug()
      

      This change would leave the SCSS as the primary compiler with a CSS fallback.

      It would be good if we could look at deprecating this library.

        Attachments

          Activity

            People

            Assignee:
            mathewmay Mathew May
            Reporter:
            mathewmay Mathew May
            Peer reviewer:
            Bas Brands
            Integrator:
            Andrew Nicols
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 40 minutes
                2h 40m