Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65044

Gradebook uses legacy cron

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      1. Run 

        php admin/tool/task/cli/schedule_task.php --execute=\\core\\task\\grade_cron_task

        • It should work as before.
      2. Grep for grade_cron() it should not find any occurrence. 
      Test new grade history clean up task
      1. Log in as admin.
      2. Go to Site administration > Server > Tasks > Scheduled tasks
      3. Make sure a new scheduled task for grade is now available:
        Background processing for grade history cleanup has been created
      4. Make sure you are able to edit (Cog icon) and see the logs (That other sheet icon).
      5. Run 

        php admin/tool/task/cli/schedule_task.php --execute=\\core\\task\\grade_history_cleanup_task

      Show
      Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task\\grade_cron_task It should work as before. Grep for grade_cron() it should not find any occurrence.  Test new grade history clean up task Log in as admin. Go to Site administration > Server > Tasks > Scheduled tasks Make sure a new scheduled task for grade is now available: Background processing for grade history cleanup has been created Make sure you are able to edit (Cog icon) and see the logs (That other sheet icon). Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task\\grade_history_cleanup_task
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65044-master
    • Pull Master Diff URL:

      Description

      Looking gradelib.php I found another legacy cron function grade_cron(). That needs to be converted to scheduled task.

        Attachments

        1. MDL-65044.jpg
          59 kB
          Anna Carissa Sadia

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-65694 Background processing for gradebook (core\task\grade_cron_task) fails: Class 'grade_grade' not found

          • Major - Major loss of function, incorrect output
          • Closed
          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65126 component things should sit under component dirs (self-contained)

          • Minor - Minor loss of function where workaround is possible
          • Open

          Improvement - An enhancement to an existing Moodle feature. MDL-65150 Final deprecation of grade_cron()

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Shamim Rezaie
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m