Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65051

Plagiarism uses legacy cron

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Plagiarism
    • Labels:
    • Testing Instructions:
      Hide
      1. Run:

        php admin/tool/task/cli/schedule_task.php --execute=\\core\\task\\plagiarism_cron_task

      2. It should work as before.
      3. Grep for plagiarism_cron() it should not find any occurrence
      4. Bonus1: Install a real plagiarism plugin, such https://moodle.org/plugins/plagiarism_vericite and make sure it still works as before. (requires cron execution using the command above).
      5. Bonus2: As a complementaty test, installing and enabling https://github.com/stronk7/moodle-plagiarism_dummypla should also allow you to verify that the plagiarism machinery continues working ok (this one is cron-less). Just create a couple of forum posts, one of the containing the "plagiarism" word and it will be detected.
      Show
      Run: php admin/tool/task/cli/schedule_task.php --execute=\\core\\task\\plagiarism_cron_task It should work as before. Grep for plagiarism_cron() it should not find any occurrence Bonus1: Install a real plagiarism plugin, such https://moodle.org/plugins/plagiarism_vericite and make sure it still works as before. (requires cron execution using the command above). Bonus2: As a complementaty test, installing and enabling https://github.com/stronk7/moodle-plagiarism_dummypla should also allow you to verify that the plagiarism machinery continues working ok (this one is cron-less). Just create a couple of forum posts, one of the containing the "plagiarism" word and it will be detected.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65051-master
    • Pull Master Diff URL:

      Description

      Doing a quick search I found another legacy cron function plagiarism_cron() on plagiarismlib.lib. That needs to be converted to scheduled task.

        Attachments

          Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65126 component things should sit under component dirs (self-contained)

          • Minor - Minor loss of function where workaround is possible
          • Open
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-65835 deprecate plagiarism_get_form_elements()

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Peter Dias
              Participants:
              Component watchers:
              Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 40 minutes
                  2h 40m