Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65059

"Block [user]" language string confused with "Block [plugin type]" language string in message dialogue

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Make sure that you have purged all caches, because both language strings as well as Mustache templates are cached in localstorage in the browser! If you want to be really sure, make a new, clean install with just this patch and only start installing and using it AFTER the patch has been applied.

      1. In a site with messaging enabled and a couple of users enrolled in a course.
      2. Logged as user 1, start a messaging conversation with user 2.
      3. In the conversation, open the action menu.
      4. Select "Block user".
      5. Verify that the first button in the confirmation dialogue reads "Block".
      Show
      Make sure that you have purged all caches, because both language strings as well as Mustache templates are cached in localstorage in the browser! If you want to be really sure, make a new, clean install with just this patch and only start installing and using it AFTER the patch has been applied. In a site with messaging enabled and a couple of users enrolled in a course. Logged as user 1, start a messaging conversation with user 2. In the conversation, open the action menu. Select "Block user". Verify that the first button in the confirmation dialogue reads "Block".
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull 3.6 Branch:
    • Pull Master Branch:

      Description

      When you try to block a user, a confirmation dialogue appears. This dialogue uses the string 'block' in 'core' for labelling the confirmation button. This does not appear to be a problem in English, but in German it is, because the current string is intended as:

      2006-09-05 09:16 UTC
      moodler <moodler> New string for blocks

      (according to AMOS).
       
      This means that I cannot translate it to something meaningful, such as "Person sperren", because that would also change translations of the Block plugin type. There already is a string 'blockuser' in 'core_message', which I think is the intended string. This is also the string that is used in the popup menu from which you can select the action "Block user".
      If we use that string, the confirmation button has the same label as the menu entry, which I think makes sense for a confirmation action.

        Attachments

        1. after.png
          after.png
          7 kB
        2. before.png
          before.png
          6 kB
        3. image-2019-03-21-08-08-50-291.png
          image-2019-03-21-08-08-50-291.png
          17 kB

          Activity

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m