Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.6, 3.7.4, 3.8.1, 3.9, 3.10, 4.0
-
Component/s: Accessibility, HTML and CSS, Quiz, Themes
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_310_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
-
Fixed Branches:MOODLE_38_STABLE, MOODLE_39_STABLE
-
Pull from Repository:
-
Pull 3.8 Branch:
MDL-65074-38 -
Pull 3.9 Branch:
MDL-65074-39 -
Pull 3.10 Branch:
MDL-65074-310 -
Pull Master Branch:
-
Pull Master Diff URL:
Description
The quiz navigation buttons in the side bar will become invisible if you change the btn-secondary color to be white (which would generally be a side effect of turning the button color itself darker to the point that dark text no longer works on it).
This is because the buttons declare themselves as being .btn-secondary and so inherit the colors from that, but then override only the background to be $card-bg, without changing the text color.
If $card-bg and btn-secondary text color are similar, the buttons become unreadable. if they're identical then no-one will be able to read them, but if they're just close then it'll be hard for people with vision impairment to read them.
I think the general solution is not to use btn-secondary on buttons that are intended to have a visual display different from btn-secondary, so possibly some special btn- class for these buttons, as they are quite unique in their behaviour and appearance. Possibly this should use color-yiq to figure out if the text should be dark or light given the buton background color.