Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.5.5, 3.6.3, 3.7
-
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
-
MOODLE_35_STABLE, MOODLE_36_STABLE
-
MDL-65081-master -
- Copy test_selects.php
to your Moodle instance's root folder. - Open it on your browser: [YOUR_MOODLE_URL]/test_selects.php
Single select
- Check the Single select element visually.
- Confirm that its label is shown in bold font.
- Confirm that it's not disabled.
- Inspect the label of the select element.
- Confirm that its "for" attribute is not set to "fake_id"
- Confirm that it has a "class" attribute which is set to 'p-1'
- Inspect the select element.
- Confirm that you see the attributes with the following values:
data-action some action data-something Some cool data class custom-select singleselect title This is the real title
URL select
- Check the URL select element visually.
- Confirm that its label is shown in bold font.
- Confirm that it's not disabled.
- Inspect the label of the select element.
- Confirm that its "for" attribute is not set to "fake_id"
- Confirm that it has a "class" attribute which is set to 'p-1'
- Inspect the select element.
- Confirm that you see the attributes with the following values:
data-action some action data-something Some cool data class custom-select urlselect title This is the real title
Copy test_selects.php to your Moodle instance's root folder. Open it on your browser: [YOUR_MOODLE_URL] /test_selects.php Single select Check the Single select element visually. Confirm that its label is shown in bold font. Confirm that it's not disabled. Inspect the label of the select element. Confirm that its " for " attribute is not set to " fake_id " Confirm that it has a " class " attribute which is set to ' p-1 ' Inspect the select element. Confirm that you see the attributes with the following values: data-action some action data-something Some cool data class custom-select singleselect title This is the real title URL select Check the URL select element visually. Confirm that its label is shown in bold font. Confirm that it's not disabled. Inspect the label of the select element. Confirm that its " for " attribute is not set to " fake_id " Confirm that it has a " class " attribute which is set to ' p-1 ' Inspect the select element. Confirm that you see the attributes with the following values: data-action some action data-something Some cool data class custom-select urlselect title This is the real title - Copy test_selects.php
Description
The \single_select::export_for_template() doesn't set the attributes. For example:
$attributes = [
|
'data-action' => 'some action'
|
];
|
echo $OUTPUT->single_select('#', 'action', $options, null, ['' => 'choosedots'], 'formid', $attributes);
|
The HTML for the select element doesn't include the 'data-action' attribute.
Attachments
Issue Links
- will help resolve
-
MDL-61043 Provide a more consistent and better way of selecting and deselecting all items in a list
-
- Open
-
