Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65083

Update uses of pull-xs-right

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.6.6, 3.7.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as Admin
      2. Navigate to Site Administration > Users > Permissions > Define Roles
      3. Click the Add a new role button
      4. Choose any role as the role archetype and click "Continue" (do not upload any file)
      5. *Verify *the help icons next to the form labels are aligned right.
         
      Show
      Login as Admin Navigate to Site Administration > Users > Permissions > Define Roles Click the Add a new role button Choose any role as the role archetype and click "Continue" (do not upload any file) *Verify *the help icons next to the form labels are aligned right.  
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65083-master
    • Story Points:
      3
    • Sprint:
      Moppies Moodle 3.8 Sprint 1, Moppies Moodle 3.8 Sprint 2, Moppies Moodle 3.8 Sprint 3, Moppies Moodle 3.8 Sprint 4, Moppies Moodle 3.8 Sprint 5

      Description

      Due to updates to bootstrap - the pull-xs-right no longer has the "float: right" effect and places where this is used now look misaligned.

      fa-pull-right, pull-right and float-right do currently work on boost.

      float-right comes from the current version of bootstrap (theme specific)

      fa-pull-right is from font awesome (theme specific)

      pull-right is in the bootstrap 2 compatibility file and works on all themes. 

      pull-right seems like the safest option since it has been supported for a long time in Moodle and we can updated it in a single place if it needs changing due to theme changes.

       

        Attachments

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            damyon Damyon Wiese
            Peer reviewer:
            Luca Bösch
            Integrator:
            Adrian Greeve
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 40 minutes
                2h 40m