Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.6
-
Component/s: Forms Library
-
Labels:
-
Testing Instructions:
Test #1
- Log in as admin
- Go to Site Home
- Click on the cog icon and chose "more"
- Go to Question bank > questions
- Create a new question of any type. For example a True/False question
- After you created the question, click on the tag icon next to the question in the question bank
- Enter "t1" in the tag element but do not click Enter
- Without clicking anywhere else on the page press "Save changes"
- Click on the tag icon for the question again and verify that the question is tagged with "t1"
- Enter "t2" in the tag element but do not click Enter
- Do this step very quick (in less than half a second)
- press tab
- press enter
- Click on the tag icon for the question again and verify that the question is tagged with "t1" and "t2"
Test #2
- Download the test patch: 0001-MDL-65102-calendar-TEST-PATCH.patch
to your Moodle instance's root folder. - On your terminal, go to your moodle root folder and apply the test patch: "git am 0001-
MDL-65102-calendar-TEST-PATCH.patch" - Purge the caches.
- Go to your dashboard and click on month name in the calendar block
- Open JS console
- Press "New event"
- Fill the name of the event
- Enter something in the tag element but do not click Enter
- Without clicking anywhere else on the page press "Submit"
- Verify that you don't see any error in the console coming from createItem
Test #1 Log in as admin Go to Site Home Click on the cog icon and chose "more" Go to Question bank > questions Create a new question of any type. For example a True/False question After you created the question, click on the tag icon next to the question in the question bank Enter "t1" in the tag element but do not click Enter Without clicking anywhere else on the page press "Save changes" Click on the tag icon for the question again and verify that the question is tagged with "t1" Enter "t2" in the tag element but do not click Enter Do this step very quick (in less than half a second) press tab press enter Click on the tag icon for the question again and verify that the question is tagged with "t1" and "t2" Test #2 Download the test patch: 0001-MDL-65102-calendar-TEST-PATCH.patch to your Moodle instance's root folder. On your terminal, go to your moodle root folder and apply the test patch: " git am 0001- MDL-65102 -calendar-TEST-PATCH.patch " Purge the caches. Go to your dashboard and click on month name in the calendar block Open JS console Press "New event" Fill the name of the event Enter something in the tag element but do not click Enter Without clicking anywhere else on the page press "Submit" Verify that you don't see any error in the console coming from createItem -
Affected Branches:MOODLE_36_STABLE
-
Fixed Branches:MOODLE_35_STABLE, MOODLE_36_STABLE
-
Pull from Repository:
-
Pull 3.5 Branch:
MDL-65102-35 -
Pull 3.5 Diff URL:
-
Pull Master Branch:
MDL-65102-master -
Pull Master Diff URL:
-
Sprint:Workplace for Moodle 3.7
Description
I am working on a modal form that contains an autocomplete element to add tags and I just found out that if I type a new tag and I press Save on the form (without pressing enter or clicking anywhere else in the form) I get this exception message:
jquery-3.2.1.js:3860 jQuery.Deferred exception: Cannot read property 'split' of undefined TypeError: Cannot read property 'split' of undefined at createItem |
This happens because on blur tries to work with an element that no longer exists. One proposal to solve this problem that Marina gave me could be adding
&& $('#' + state.inputId).length |
on this if condition:
--- a/lib/amd/src/form-autocomplete.js
|
+++ b/lib/amd/src/form-autocomplete.js
|
@@ -709,7 +709,7 @@ function($, log, str, templates, notification, LoadingIcon) { |
var focusElement = $(document.activeElement); // Only close the menu if the input hasn't regained focus. |
- if (focusElement.attr('id') != inputElement.attr('id')) { |
+ if (focusElement.attr('id') != inputElement.attr('id') && $('#' + state.inputId).length) { |
if (options.tags) { |
pendingPromise.then(function() {
|
return createItem(options, state, originalSelect); |
