Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65127

Messaging: add aria-label to sections to explain the meaning of the numbers

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Please test these UI changes on:

      1. Clean (3.6), Classic (master) and Boost (3.6 and master) themes
      2. Supported browsers
      3. Viewing the page html code using each browser facilites (Inspector...).

      Setup

      1. Log in as an admin
      2. Create a course C1
      3. Enrol students s1, s2 and s3 to C1
      4. Create group g1 and enable group messaging
      5. Add s1, s2 and s3 to g1
      6. Logout
      7. Log in as s1
      8. Send some messages to s2
      9. Send some messages to s3
      10. Send some messages to g1
      11. Send a contact request to s2
      12. Star s2 conversation
      13. Log out.
      14. Log in as s2
      15. Accept s1 contact request
      16. Send some messages to s1
      17. Send some messages to g1
      18. Log out.
      19. Log in as s3
      20. Send a Contact request to s1
      21. Send some messages to s1
      22. Send some messages to g1

       

      Testing scenario 1: Overview

      1. Log in as s1
      2. CHECK the number over the notifications icon with the data-region="count-container" has the aria-label="There are x unread notifications" attribute
      3. CHECK the number over the message icon with the data-region="count-container" has the aria-label="There are x unread conversations" attribute
      4. Open the message drawer
      5. CHECK the number near the Contacts with data-region="contact-request-count" has the aria-label="There are x pending contact requests" attribute
      6. For each section (Starred, Group and Private):
      7. CHECK the element containing the total conversations (data-region="section-total-count-container") has the aria-label="There are x total conversations" attribute
      8. CHECK the element containing the unread conversations (data-region="section-unread-count") has the aria-label="There are x unread conversations" attribute
      9. CHECK the conversations with unread messages have the aria-label="There are 2 unread messages" in the element data-region="unread-count"
      10. CHECK the last date message element (data-region="last-message-date") has the aria-hidden="true" attribute
      Show
      Please test these UI changes on: Clean (3.6), Classic (master) and Boost (3.6 and master) themes Supported browsers Viewing the page html code using each browser facilites (Inspector...). Setup Log in as an admin Create a course C1 Enrol students s1, s2 and s3 to C1 Create group g1 and enable group messaging Add s1, s2 and s3 to g1 Logout Log in as s1 Send some messages to s2 Send some messages to s3 Send some messages to g1 Send a contact request to s2 Star s2 conversation Log out. Log in as s2 Accept s1 contact request Send some messages to s1 Send some messages to g1 Log out. Log in as s3 Send a Contact request to s1 Send some messages to s1 Send some messages to g1   Testing scenario 1: Overview Log in as s1 CHECK the number over the notifications icon with the data-region="count-container" has the aria-label="There are x unread notifications" attribute CHECK the number over the message icon with the data-region="count-container" has the aria-label="There are x unread conversations" attribute Open the message drawer CHECK the number near the Contacts with  data-region="contact-request-count" has the  aria-label="There are x pending contact requests" attribute For each section (Starred, Group and Private): CHECK the element containing the total conversations ( data-region="section-total-count-container" ) has the  aria-label="There are x total conversations" attribute CHECK the element containing the unread conversations ( data-region="section-unread-count" ) has the  aria-label="There are x unread conversations" attribute CHECK the conversations with unread messages have the  aria-label="There are 2 unread messages" in the element  data-region="unread-count" CHECK the last date message element ( data-region="last-message-date" ) has the  aria-hidden="true"  attribute
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-65127-master

      Description

      • All the links for "Starred, Group and Private" are unreadable - there is no information given to say what the number after the name means and it is often not understandable.
      • The brackets are read as well which makes the number undecipherable.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 5 minutes
                  1d 5m