Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65144

Logo on Boost is not scaled on login page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.6.1
    • Fix Version/s: 3.7
    • Component/s: Administration, Themes
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Login as admin
      2. Set Admin setting "Self registration" to "Email based self registration"
      3. Set the "agriculture" image attached to this issue as the site logo "core_admin | logo"
      4. Set the same image as the logo for the clean theme: "theme_clean | logo"

      Test

      Repeat this test in both Clean and Boost themes.

      1. Verify the logo on the home page (not logged in) does not exceed the width of the page (it should be only about 20 pixels tall though)
      2. Verify the logo on the signup page (not logged in) does not exceed the width of the page (it should be only about 20 pixels tall though)

      (To get to the signup page, logout, go to the site home page, then click on a course, then press the "Create new account" button)

      1. Verify the logo on the login page (not logged in) does not exceed the width of the page (it should be only about 20 pixels tall though)
      2. Verify the logo on the course page (logged in this time) does not exceed the width of the page (it should be only about 20 pixels tall though)

       

      Show
      Setup Login as admin Set Admin setting "Self registration" to "Email based self registration" Set the "agriculture" image attached to this issue as the site logo "core_admin | logo" Set the same image as the logo for the clean theme: "theme_clean | logo" Test Repeat this test in both Clean and Boost themes. Verify the logo on the home page (not logged in) does not exceed the width of the page (it should be only about 20 pixels tall though) Verify the logo on the signup page (not logged in) does not exceed the width of the page (it should be only about 20 pixels tall though) (To get to the signup page, logout, go to the site home page, then click on a course, then press the "Create new account" button) Verify the logo on the login page (not logged in) does not exceed the width of the page (it should be only about 20 pixels tall though) Verify the logo on the course page (logged in this time) does not exceed the width of the page (it should be only about 20 pixels tall though)  
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-65144-master

      Description

       The logo help says:

      "A full logo to be used as decoration by some themes (such as core themes). This image can be quite high resolution because it will be scaled down for use (and cached for performance). Logos that are wider than they are high usually give better results. Formats accepted: PNG and JPG."

      On Boost in 3.6.1 it is not scaled.  This seems to be a regression.

       

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 45 minutes
                  4h 45m