Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65184

Remove the unused footer template from Classic theme

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      For manual testing, using the classic theme, visually inspect a site to verify the footer is still in the site on the Columns layout i.e. Site dashboard with 1, 2 & 3 columns.

      For automated testing, there are minimal behat files that reference the footer, however one relevant test is to run behat with @core_auth --suite=classic.

      A git grep for theme_classic/footer should also show no usages.

      Show
      For manual testing, using the classic theme, visually inspect a site to verify the footer is still in the site on the Columns layout i.e. Site dashboard with 1, 2 & 3 columns. For automated testing, there are minimal behat files that reference the footer, however one relevant test is to run behat with @core_auth --suite=classic. A git grep for theme_classic/footer should also show no usages.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:

      Description

      The footer within the Classic theme (/theme/classic/templates/core/footer.mustache) is not actually used, it uses the Boost footer in its templates. Given the footer is also almost identical (but is missing some aria elements), it should be removed from the theme.

        Attachments

          Activity

            People

            Assignee:
            mathewmay Mathew May
            Reporter:
            michaelh Michael Hawkins
            Peer reviewer:
            Michael Hawkins
            Integrator:
            David Monllaó
            Tester:
            Bas Brands
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              20/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 15 minutes
                3h 15m