Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65184

Remove the unused footer template from Classic theme

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Minor
    • 3.7
    • 3.7
    • Themes
    • MOODLE_37_STABLE
    • MOODLE_37_STABLE
    • Hide

      For manual testing, using the classic theme, visually inspect a site to verify the footer is still in the site on the Columns layout i.e. Site dashboard with 1, 2 & 3 columns.

      For automated testing, there are minimal behat files that reference the footer, however one relevant test is to run behat with @core_auth --suite=classic.

      A git grep for theme_classic/footer should also show no usages.

      Show
      For manual testing, using the classic theme, visually inspect a site to verify the footer is still in the site on the Columns layout i.e. Site dashboard with 1, 2 & 3 columns. For automated testing, there are minimal behat files that reference the footer, however one relevant test is to run behat with @core_auth --suite=classic. A git grep for theme_classic/footer should also show no usages.

    Description

      The footer within the Classic theme (/theme/classic/templates/core/footer.mustache) is not actually used, it uses the Boost footer in its templates. Given the footer is also almost identical (but is missing some aria elements), it should be removed from the theme.

      Attachments

        Activity

          People

            mathewmay Mathew May
            michaelh Michael Hawkins
            Michael Hawkins Michael Hawkins
            David Monllaó David Monllaó
            Bas Brands Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 15 minutes
                3h 15m

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.