Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65191

Badges uses legacy cron

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide
      New scheduled tasks tests
      1. Log in as admin.
      2. Go to Site administration > Server > Tasks > Scheduled tasks
      3. Search for badges.
      4. Make sure a new scheduled task for badge is now available:
        Background processing for sending badges notifications
      5. Make sure you are able to edit (Cog icon) and see the logs (That other sheet icon).
      6. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task
        badges_cron_task
        • It should work as before.
      7. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task
        badges_message_task
        • It should work without error.
      8. Verify that disabling badges both tasks above stop performing stuff.
      Deprecation test
      1. Make sure the badge/cron.php has been removed.
      Show
      New scheduled tasks tests Log in as admin. Go to Site administration > Server > Tasks > Scheduled tasks Search for badges . Make sure a new scheduled task for badge is now available: Background processing for sending badges notifications Make sure you are able to edit (Cog icon) and see the logs (That other sheet icon). Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task badges_cron_task It should work as before. Run php admin/tool/task/cli/schedule_task.php --execute=\\core\\task badges_message_task It should work without error. Verify that disabling badges both tasks above stop performing stuff. Deprecation test Make sure the badge/cron.php has been removed.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65191-master
    • Pull Master Diff URL:

      Description

      Badges have some legacy cron functions that needs to be converted to scheduled tasks.

        Attachments

          Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-65243 badges_calculate_message_schedule() requires updates

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              lameze Simey Lameze
              Peer reviewer:
              Damyon Wiese Damyon Wiese
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 15 minutes
                  2h 15m