[MDL-65203] Tab characters in event names produce malformed JSON in mustache template - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.6.3, 3.7.8, 3.8.5, 3.9.2, 3.10.4, 3.11
Fix Version/s: 3.10.5, 3.11.1
Component/s: Blocks, JavaScript
Labels:

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
https://github.com/dcai/moodle.git
Pull 3.9 Branch:
~~MDL-65203~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/b56affcfe6...dcai:MDL-65203-39
Pull 3.11 Branch:
~~MDL-65203~~-311
Pull 3.11 Diff URL:
https://github.com/dcai/moodle/compare/94f2d3fc4b...MDL-65203-311
Pull Master Branch:
~~MDL-65203~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/0b69b37f04...dcai:MDL-65203-master
Testing Instructions:
Hide

Create a course

Create an assignment with the following:

Give the assignment a name with tabs, you can create one in text editor by press `tab` key, copy the tab character and paste in assignment name

Enrol a student in the course and log in as student

Browse to the dashboard page

On the timeline block, select "Next 7 days" from the dropdown with the clock icon on it

No errors observed, before this fix, you get this error: "JSON.parse: bad control character in string literal at line 1 column 14 of the JSON data"
Show
Create a course Create an assignment with the following: Give the assignment a name with tabs, you can create one in text editor by press `tab` key, copy the tab character and paste in assignment name Enrol a student in the course and log in as student Browse to the dashboard page On the timeline block, select "Next 7 days" from the dropdown with the clock icon on it No errors observed, before this fix, you get this error: "JSON.parse: bad control character in string literal at line 1 column 14 of the JSON data"

Story Points:
2
Sprint:
Internationals - 3.11 Sprint 5

Description

Create a course
Create an assignment with the following:
- Give the assignment a name like: "A. my name chef" - NB: There is a TAB character (https://graphemica.com/0009) between the "A." and "my"
- Set the due date for like 2 days from now
Enrol a student in the course and log in as them
Browse to the dashboard page
On the timeline block to the top right of the page select "Next 7 days" from the dropdown with the clock icon on it
You should get an error from the browser (it varies from browser to browser), in firefox it says "JSON.parse: bad control character in string literal at line 1 column 14 of the JSON data"

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-05-14-09-37-40-996.png
72 kB
14/May/20 9:37 PM
image-2020-05-14-09-41-21-074.png
17 kB
14/May/20 9:41 PM
MDL-65203.jpg
47 kB
20/May/21 12:58 PM

Activity

People

Assignee:: Dongsheng Cai

Reporter:: cameron1729

Peer reviewer:: Sujith Haridasan

Integrator:: Adrian Greeve

Tester:: Anna Carissa Sadia

Participants:: Adrian Greeve, Anna Carissa Sadia, cameron1729, CiBoT, Dongsheng Cai, Douglas Nantes Gualberto, Eric Merrill, kaitkrull, Lee Goldsworthy, Nathan Rosenquist, Philipp Hager, Philipp Hager, Shamim Rezaie, Stephan Bauer, Sujith Haridasan

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 12 Vote for this issue

Watchers:: 24 Start watching this issue

Dates

Created:: 28/Mar/19 4:09 PM

Updated:: 02/Jul/21 1:28 PM

Resolved:: 20/May/21 6:02 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 45m