Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65205

Messaging interface assumes secondary color is light shade

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Login as Admin

      1. Create a new user s1
      2. Open the messaging interface search for user s1 and send user s1 a message
      3. Login as user s1
      4. Reply to the message send by the admin user
      5. Verfiy the send message is a light shade of gray
      6. Verify the received message has a white background color
      7. Verify the message container background has a lighter shade of gray
      8. Verify you can read the message time in the message bubble
      9. Verify you can see the day the messages were send in the message container

       

      Now install the attached Moodle preset

      • Navigate to Site Administration -> appearance -> Boost
      • Upload the Moodle preset file in Preset Files
      • Select the Moodle preset file in Theme Preset
      • Now test the messaging again for steps 5 to 9 from the test above.
      Show
      Login as Admin Create a new user s1 Open the messaging interface search for user s1 and send user s1 a message Login as user s1 Reply to the message send by the admin user Verfiy  the send message is a light shade of gray Verify  the received message has a white background color Verify  the message container background has a lighter shade of gray Verify you can read the message time in the message bubble Verify  you can see the day the messages were send in the message container   Now install the attached Moodle preset Navigate to Site Administration -> appearance -> Boost Upload the Moodle preset file in Preset Files Select the Moodle preset file in Theme Preset Now test the messaging again for steps 5 to 9 from the test above.
    • Affected Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65205-master
    • Story Points:
      3
    • Sprint:
      Moppies Moodle 3.8 Sprint 1, Moppies Moodle 3.8 Sprint 2, Moppies Moodle 3.8 Sprint 3, Moppies Moodle 3.8 Sprint 4, Moppies Moodle 3.8 Sprint 5, Moppies Moodle 3.8 Sprint 6

      Description

      The messaging interface in Boost uses bg-secondary behind some text but assumes that it's a pale shade, since it puts hardcoded gray and dark gray text on top of it.

      The text colors should use color-yiq functions to ensure they are readable if the secondary color is set to something else.

        Attachments

        1. inverted with bg-white.png
          35 kB
          David Scotson
        2. inverted with bg-white deleted.png
          35 kB
          David Scotson
        3. MDL-65205.png
          86 kB
          Jennifer Bauzon
        4. message-test-preset.scss
          0.2 kB
          Bas Brands
        5. Screen Shot 2019-03-28 at 10.22.05.png
          22 kB
          David Scotson
        6. Screen Shot 2019-03-28 at 10.22.32.png
          21 kB
          David Scotson
        7. Screenshot 2019-07-02 at 10.08.27.png
          210 kB
          Bas Brands

          Issue Links

            Activity

              People

              • Assignee:
                basbrands Bas Brands
                Reporter:
                bawjaws David Scotson
                Peer reviewer:
                David Scotson
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Jennifer Bauzon
                Participants:
                Component watchers:
                Amy Groshek, David Scotson, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 19 minutes
                  1d 19m