Right now, both the course and category recycle bins are using backup::MODE_AUTOMATED (since
MDL-63263) to perform their backups.
And, while working ok, has some tradeoffs:
- It's a mode that was incepted for another type of backups (scheduled ones). And performs some special actions like storing files in different places (prevented via hack @
- It makes recycle bin backups dependent of scheduled backup defaults. So, if different defaults are desired, it's impossible.
- It's confusing and prone to errors whenever we modify any automated functionality.
Because of all those problems, this is a proposal about to create a new backup::MODE_RECYCLEBIN so all recycle bin backups will have their own mode, with own settings and own logic.
HEADs UP: Don't forget the "hack" that was applied in
MDL-65218 to keep backup::MODE_AUTOMATED working ok as recycle bin mode. And also the note in the admin setting @ MDL-63263 about automated defaults being also used by recycle bin ops.