[MDL-65229] Allow cron cli option to remotely stop all crons - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9
Fix Version/s: 3.9
Component/s: Administration, Installation, Tasks
Labels:
- CatalystIT
- ci
- partner
- release_notes

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull Main Branch:
~~MDL-65229~~-stop-cron
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/800563e4...brendanheywood:MDL-65229-stop-cron
Testing Instructions:

Hide

1) Install this to make testing easier:

https://github.com/catalyst/moodle-tool_testtasks

2) Run cronhelp to see new option:

php admin/cli/cron.php -h

3) In terminal 1 run cron:

php admin/cli/cron.php

4) In terminal 2 after a couple seconds remotely kill all crons:

php admin/cli/cron.php --stop

5) Repeat using ad hoc tasks. In terminal 1:

Queue up some tasks

php admin/tool/testtasks/cli/queue_adhoc_tasks.php -d=1 -n=20

Now run them:

php admin/tool/task/cli/adhoc_task.php --execute

6) In terminal 2 wait a few seconds and then kill it remotely:

php admin/cli/cron.php --stop

Show
1) Install this to make testing easier: https://github.com/catalyst/moodle-tool_testtasks 2) Run cronhelp to see new option: php admin/cli/cron.php -h 3) In terminal 1 run cron: php admin/cli/cron.php 4) In terminal 2 after a couple seconds remotely kill all crons: php admin/cli/cron.php --stop 5) Repeat using ad hoc tasks. In terminal 1: Queue up some tasks php admin/tool/testtasks/cli/queue_adhoc_tasks.php -d=1 -n=20 Now run them: php admin/tool/task/cli/adhoc_task.php --execute 6) In terminal 2 wait a few seconds and then kill it remotely: php admin/cli/cron.php --stop

Description

We now have the ability to throttle cron process run time since ~~MDL-64347~~.

These settings are only honored between runs of scheduled tasks in the cronlib, but some heavy tasks can still take many many hours (> 24 hours on big sites). Most of these scheduled tasks are processing some sort of large queue and it should also be able check whether it should continue between queue items.

The end game here is to eventually allow much fast clean exiting of cron when doing a new release, and this should be much simpler and a less contentious than ~~MDL-57852~~

Then exiting gracefully via SIGTERM could be built on top of this ~~MDL-59594~~

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-12-04-09-44-03-717.png
152 kB
04/Dec/19 9:44 AM

Issue Links

has a non-specific relationship to

MDL-65201 Automated backup course ordering

Closed

has been marked as being related by

MDL-59594 Allow graceful fast exit of cron.php / adhoc_task.php via SIGTERM or SIGINT

Closed

MDL-64359 Call shutdown handlers on SIGINT/SIGTERM

Closed

will help resolve

MDL-57852 Disable cron at site config level via gui and cli with fast shutdown

Closed

Activity

People

Assignee:: Brendan Heywood

Reporter:: Brendan Heywood

Peer reviewer:: Matt Porritt

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, Brendan Heywood, CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Matt Porritt, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 01/Apr/19 6:48 AM

Updated:: 05/Jun/20 2:42 PM

Resolved:: 05/Dec/19 8:45 PM

Fix Release Date:: 15/Jun/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 20m