Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.5.5, 3.6.3, 3.7, 3.8
-
Component/s: Badges
-
Testing Instructions:
-
Affected Branches:MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
-
Fixed Branches:MOODLE_36_STABLE, MOODLE_37_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-65243-master -
Pull Master Diff URL:
Description
The badges function badges_calculate_message_schedule() is supposed to calculate the time the next message should be sent for a badge.
It is incorrect because of 2 things:
- There are not 210 days in a month
- Date / times can never be calculated by adding seconds to a timestamp - they should always use https://docs.moodle.org/dev/Time_API or they will always be incorrect
Attachments
Issue Links
- Discovered while testing
-
MDL-65191 Badges uses legacy cron
-
- Closed
-