Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65246

question_attempt::$timemodified should not be public

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.6.3
    • Fix Version/s: None
    • Component/s: Questions
    • Labels:
      None
    • Affected Branches:
      MOODLE_36_STABLE

      Description

      question_attempt is a completely encapsulated class (all fields protected, with getters where needed), except for $timemodified, which is public. (Before MDL-65245 it was undeclared, meaning that it was effectively public, and it seems that the privacy code is relying on that.)

      This field should be changed to be protected like everything else.

        Attachments

          Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-65245 Question engine: sometimes step data is a string, and sometimes an int

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                timhunt Tim Hunt
                Participants:
                Component watchers:
                Tim Hunt, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated: