Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65255

Vimeo script (for frame embedding) should not require width and height

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6.3
    • Fix Version/s: 3.7
    • Component/s: Other
    • Labels:
    • Testing Instructions:
      Hide
      1. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      2. Create a Token in the mobile app service for any user in the site (not an admin account)
        • Click on Site administration ► Plugins ► Web services ► Manage tokens
      3. Open the following URL in a browser, replacing the URL and wstoken to use yours: http://localhost/m/stable_master/media/player/vimeo/wsplayer.php?video=34141064&token=3af67232a7596ceb658df4db329e5ad6&width=420&height=236
      4. Confirm that you see a Vimeo video with a fixed width and height: 420x236
      5. Now, remove the width and height parameters and values from the URL and open it again in a browser
      6. Confirm that the Vimeo video now uses the complete screen
      Show
      As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Create a Token in the mobile app service for any user in the site (not an admin account) Click on Site administration ► Plugins ► Web services ► Manage tokens Open the following URL in a browser, replacing the URL and wstoken to use yours: http://localhost/m/stable_master/media/player/vimeo/wsplayer.php?video=34141064&token=3af67232a7596ceb658df4db329e5ad6&width=420&height=236 Confirm that you see a Vimeo video with a fixed width and height: 420x236 Now, remove the width and height parameters and values from the URL and open it again in a browser Confirm that the Vimeo video now uses the complete screen
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65255-master
    • Pull Master Diff URL:

      Description

      Those fields should be optional and use responsive classes or force full view by styles otherwise

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MOBILE-2960 Improve Vimeo embedding for 3.7 onwards

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Pau Ferrer Pau Ferrer
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 25 minutes
                  25m