[MDL-65255] Vimeo script (for frame embedding) should not require width and height - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.3
Fix Version/s: 3.7
Component/s: Other
Labels:
- BMA
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
git://github.com/jleyva/moodle.git
Pull Master Branch:
~~MDL-65255~~-master
Pull Master Diff URL:
https://github.com/jleyva/moodle/compare/280cfdf05c...MDL-65255-master
Testing Instructions:
Hide

As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings

Create a Token in the mobile app service for any user in the site (not an admin account)

Click on Site administration ► Plugins ► Web services ► Manage tokens

Open the following URL in a browser, replacing the URL and wstoken to use yours: http://localhost/m/stable_master/media/player/vimeo/wsplayer.php?video=34141064&token=3af67232a7596ceb658df4db329e5ad6&width=420&height=236

Confirm that you see a Vimeo video with a fixed width and height: 420x236

Now, remove the width and height parameters and values from the URL and open it again in a browser

Confirm that the Vimeo video now uses the complete screen
Show
As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Create a Token in the mobile app service for any user in the site (not an admin account) Click on Site administration ► Plugins ► Web services ► Manage tokens Open the following URL in a browser, replacing the URL and wstoken to use yours: http://localhost/m/stable_master/media/player/vimeo/wsplayer.php?video=34141064&token=3af67232a7596ceb658df4db329e5ad6&width=420&height=236 Confirm that you see a Vimeo video with a fixed width and height: 420x236 Now, remove the width and height parameters and values from the URL and open it again in a browser Confirm that the Vimeo video now uses the complete screen

Description

Those fields should be optional and use responsive classes or force full view by styles otherwise

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-04-22-16-54-03-814.png
543 kB
22/Apr/19 4:54 PM

Issue Links

blocks

MOBILE-2960 Improve Vimeo embedding for 3.7 onwards

Closed

Activity

People

Assignee:: Juan Leyva

Reporter:: Juan Leyva

Peer reviewer:: Pau Ferrer

Integrator:: David Monllaó

Tester:: Janelle Barcega

Participants:: CiBoT, David Monllaó, Janelle Barcega, Juan Leyva, Pau Ferrer

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 03/Apr/19 5:22 PM

Updated:: 23/Apr/19 11:52 PM

Resolved:: 23/Apr/19 11:52 PM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

25m