Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65273

Allow role modal has unstyled buttons

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.5, 3.6.3
    • Fix Version/s: 3.5.6, 3.6.4
    • Component/s: Roles / Access
    • Labels:
    • Testing Instructions:
      Hide
      1. Test in Boost and Classic
      2. As a teacher, in your course, in an activity, select "Permissions"
      3. On a capability, click the + icon under the "Roles with permission" column.
      4. Verify the buttons are properly styled and look consistent with Moodle's secondary buttons.
      5. Click the + icon in any row under the "Prohibited" column.
      6. Confirm that the buttons also look properly styled.

      Note: You might encounter the error "Cannot read property 'filter' of undefined". Ignore this as it will be fixed in MDL-64523.

      Show
      Test in Boost and Classic As a teacher, in your course, in an activity, select "Permissions" On a capability, click the + icon under the " Roles with permission " column. Verify the buttons are properly styled and look consistent with Moodle's secondary buttons. Click the + icon in any row under the " Prohibited " column. Confirm that the buttons also look properly styled. Note: You might encounter the error " Cannot read property 'filter' of undefined ". Ignore this as it will be fixed in MDL-64523 .
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-65273-master

      Description

      When you assign a role under "Permissions" the role buttons to choose from are not styled.

      To reproduce:
       

      1. As teacher, in your course, in an activity, select "Permissions"
      2. On a capability, click the + icon.

        Attachments

        1. add-a-block.png
          add-a-block.png
          109 kB
        2. image-2019-05-02-10-39-12-807.png
          image-2019-05-02-10-39-12-807.png
          337 kB
        3. MDL-65273-after.png
          MDL-65273-after.png
          85 kB
        4. MDL-65273-after-with-borders.png
          MDL-65273-after-with-borders.png
          38 kB
        5. MDL-65273-before.png
          MDL-65273-before.png
          83 kB

          Issue Links

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              lucaboesch Luca Bösch
              Peer reviewer:
              Alexander Bias
              Integrator:
              Jun Pataleta
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 50 minutes
                  50m