Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65281

Random failures @ test_get_from_discussion_ids_private_replies

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Forum, Unit tests
    • Labels:

      Description

      Since some days ago we are getting this failure randomly:

      1) mod_forum_vaults_post_testcase::test_get_from_discussion_ids_private_replies
      Failed asserting that 2 matches expected '1'.
       
      /var/www/html/mod/forum/tests/vaults_post_test.php:231
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit --verbose "mod_forum_vaults_post_testcase" mod/forum/tests/vaults_post_test.php
      

      Usually those failures are because implicit ordering is expected and it doesn't work the same in all databases. Making it explicit uses to solve the problem. Alternatively the test can be changed to find the element before comparison.

        Attachments

          Activity

            People

            • Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Michael Hawkins
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 25 minutes
                5h 25m