[MDL-65291] Timezone dependent test results - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6, 3.7
Fix Version/s: 3.5.6, 3.6.4
Component/s: Chat, General, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-65291~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-65291~1...MDL-65291
Testing Instructions:
Hide

Requires root access to your computer.

Init your phpunit environment: php admin/tool/phpunit/cli/init.php

Download the allhours.sh script and put it in your moodle base directory.

From terminal, go to your moodle base directory and execute sudo ./allhours.sh.

You will be prompted for the root password in order to allow the script to change the system date.

Script output will run for every hour of March 15th and September 15th. Verify that all combinations end with an OK message and that the final message is "ALL OK, yay!!".

IMPORTANT: Don't forget to change your system date and time back to current once you've finished testing this (from Control Panel or whatever, it depends of your system).

Optional... without the patch applied and following the instructions above... you will get a failure @ September 15th 23:15 UTC. That's what this patch is fixing.
Show
Requires root access to your computer. Init your phpunit environment: php admin/tool/phpunit/cli/init.php Download the allhours.sh script and put it in your moodle base directory. From terminal, go to your moodle base directory and execute sudo ./allhours.sh . You will be prompted for the root password in order to allow the script to change the system date. Script output will run for every hour of March 15th and September 15th. Verify that all combinations end with an OK message and that the final message is "ALL OK, yay!!". IMPORTANT: Don't forget to change your system date and time back to current once you've finished testing this (from Control Panel or whatever, it depends of your system). Optional... without the patch applied and following the instructions above... you will get a failure @ September 15th 23:15 UTC. That's what this patch is fixing.

Description

While we cleaned a lot of the failures happening on unit tests moving from moodle tz handling to more robust php tz handling... there are still some problems that happen near TZ changes (twice a year).

This issue is about to find them and, if possible, fix them. All problems will be reported here with 1) the UTC time they happened and 2) the complete error.

A) Mon Apr 01 22:27:09 UTC 2019, Sat Apr 06 22:39:47 UTC 2019, Mon Apr 08 22:27:09 UTC 2019

mod_chat_lib_testcase::test_chat_core_calendar_provide_event_action_chattime_event_different_timezones

Failed asserting that core_calendar\local\event\value_objects\action Object &000000006f6b1e2f000000006102133e (

    'name' => 'Click here to enter the chat now'

    'url' => moodle_url Object &000000006f6b1722000000006102133e (

        'scheme' => 'https'

        'host' => 'www.example.com'

        'port' => ''

        'user' => ''

        'pass' => ''

        'path' => '/moodle/mod/chat/view.php'

        'slashargument' => ''

        'anchor' => null

        'params' => Array &0 (

            'id' => '222000'

    'itemcount' => 1

    'actionable' => true

) is null.

/var/www/html/mod/chat/tests/lib_test.php:414

/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

To re-run:

 vendor/bin/phpunit --verbose "mod_chat_lib_testcase" mod/chat/tests/lib_test.php

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

allhours.sh
0.7 kB
15/Apr/19 7:00 AM

Issue Links

is a regression caused by

MDL-63134 Update mod_chat_core_calendar_provide_event_action callback to accept $userid

Closed

will help resolve

MDL-65343 Time based unit test failure

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Simey Lameze

Integrator:: Jake Dallimore

Tester:: CiBoT

Participants:: CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Shamim Rezaie, Simey Lameze

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 08/Apr/19 12:03 AM

Updated:: 18/Apr/19 2:33 AM

Resolved:: 18/Apr/19 2:33 AM

Fix Release Date:: 13/May/19

Time Tracking

Estimated:

Remaining:

Logged:

5h 51m