Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.6.3, 3.7
-
Fix Version/s: 3.6.4
-
Component/s: Themes
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_36_STABLE, MOODLE_37_STABLE
-
Fixed Branches:MOODLE_36_STABLE
-
Pull from Repository:
-
Pull Master Branch:M65299_boost_theme-colors_override
Description
The update to Bootstrap 4 stable for theme_boost in MDL-56511 included a change to allow overriding colour maps via map-merge() such as $theme-colors.
This map-merge() change is also needed on the $theme-colors map in default.scss, otherwise child themes using Boost's default.scss cannot override $theme-colors definition in their own scsspre setting.
For clarity: It seems that $theme-colors can be overriden in Boost's scsspre, but it doesn't work when using Boost's default.scss and a child theme's scsspre. Presumably theme makers could copy Boost's default.scss into their own theme, but that would need additional work when keeping up with changes to Boost.