[MDL-65299] Allow override of BS4 $theme-colors map in default.scss - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.6.3, 3.7
Fix Version/s: 3.6.4
Component/s: Themes
Labels:
- ci
- release_notes

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_36_STABLE
Pull from Repository:
https://github.com/Dave-B/moodle.git
Pull Master Branch:
M65299_boost_theme-colors_override
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...Dave-B:M65299_boost_theme-colors_override
Testing Instructions:
Hide

Test for theme Boost

Login as admin

Navigate to Site Administration > Appearance > Boost

Click the Advanced setting tab

Copy this scss in the Raw initial SCSS field:

$theme-colors: (

primary: red

);

Save changes, then reload the page

Verify Links and (previously blue) Buttons are now red

Test for theme Classic

Login as admin

Site Administration > Appearance > Theme selector

Click the Change theme button in the Default theme section

Choose the Classic theme

Navigate to Site Administration > Appearance > Classic

Click the Advanced setting tab

Copy this scss in the Raw initial SCSS field:

$theme-colors: (

primary: green

);

Save changes, then reload the page

Verify Links and (previously blue) Buttons are now green
Show
Test for theme Boost Login as admin Navigate to Site Administration > Appearance > Boost Click the Advanced setting tab Copy this scss in the Raw initial SCSS field: $theme-colors: ( primary: red ); Save changes, then reload the page Verify Links and (previously blue) Buttons are now red Test for theme Classic Login as admin Site Administration > Appearance > Theme selector Click the Change theme button in the Default theme section Choose the Classic theme Navigate to Site Administration > Appearance > Classic Click the Advanced setting tab Copy this scss in the Raw initial SCSS field: $theme-colors: ( primary: green ); Save changes, then reload the page Verify Links and (previously blue) Buttons are now green

Description

The update to Bootstrap 4 stable for theme_boost in ~~MDL-56511~~ included a change to allow overriding colour maps via map-merge() such as $theme-colors.

This map-merge() change is also needed on the $theme-colors map in default.scss, otherwise child themes using Boost's default.scss cannot override $theme-colors definition in their own scsspre setting.

For clarity: It seems that $theme-colors can be overriden in Boost's scsspre, but it doesn't work when using Boost's default.scss and a child theme's scsspre. Presumably theme makers could copy Boost's default.scss into their own theme, but that would need additional work when keeping up with changes to Boost.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-05-03-12-42-19-756.png
142 kB
03/May/19 12:42 PM

Activity

People

Assignee:: Dave Balch

Reporter:: Dave Balch

Peer reviewer:: Bas Brands

Integrator:: Andrew Lyons

Tester:: Janelle Barcega

Participants:: Andrew Lyons, Bas Brands, CiBoT, Dave Balch, Eloy Lafuente (stronk7), Janelle Barcega

Component watchers:: Huong Nguyen, Bas Brands, Mathew May

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 08/Apr/19 10:32 PM

Updated:: 08/May/19 4:41 PM

Resolved:: 04/May/19 1:30 AM

Fix Release Date:: 13/May/19

Time Tracking

Estimated:

Remaining:

Logged:

2h 50m