Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65306

LTI Adv: external tool add may fail due to uniqueness constraint

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5.5, 3.6, 3.7
    • Fix Version/s: None
    • Labels:
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE

      Description

      Part of the LTI Advantage Assignment and Grade Services support, Moodle must retain for each grade item created for LTI the resource id and the tag as provided by the tool when the line item was created. Currently the resource id is stored using the grade item id number; as a consequence:

      1. The link may fail creation due to a uniqueness constraint on the id number field used to store the resource id
      2. The id number may be edited by the end user which would cause the tool to possibly malfunction

      The proposed fix is:

      1. Add a new column in gbs table to store resource id and use it to store the resource id
      2. Migrates existing id_number to gbs.resource_id
        1. This will require the addition of the missing gbs entries
      3. Modify the add activity flow to pass both the resource_id as hidden input to the back end and have the back end create the associated gbs entry

      The last step is similar to the work done for MDL-65305 about how tag are stored as part of the external tool add/edit flow.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              claudevervoort Claude Vervoort
              Participants:
              Component watchers:
              Adrian Greeve, Mihail Geshoski, Peter Dias
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: