Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.7
-
Fix Version/s: 3.7
-
Component/s: Backup, Performance
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_37_STABLE
-
Fixed Branches:MOODLE_37_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-65321-course-perf
Description
This is a regression introduced by MDL-28505 (master only) and should be fixed before 3.7 release (aka, must fix).
Our performance comparison scripts detected a 6% memory increase in all course view requests. Problem was traced down to the new async backups option where, irrespectively of them being enabled or no (site-wide setting), the increase happens.
In Rex Lorenzo wise words:
I see the increased in files being included is because of the notification for a pending async here:
https://github.com/moodle/moodle/compare/master...mattporritt:master_MDL-28505_Asynchronous_backup_and_restore#diff-74f014905906a752b55944bb01490677R8
So, we should not be including all the backup machinery unconditionally, the check should be really lighter, specially when the feature is disabled (also when enabled).
That's it, ciao
Attachments
Issue Links
- is a regression caused by
-
MDL-28505 Asynchronous course backup / restore
-
- Closed
-