Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65323

Favourites: address deprecated method calls in phpunit tests

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7, 3.8
    • Fix Version/s: 3.8
    • Component/s: Favourites
    • Labels:

      Description

      Some examples of deprecated methods, as detected by phpstorm:
      assertInternalType()
      assertAttributeEquals()

      Changelog for 7.5 which mentions the deprecation here (under 7.5.0 heading): [https://github.com/sebastianbergmann/phpunit/blob/7.5/ChangeLog-7.5.md

      Looks like these will be dropped for 9.0 (https://github.com/sebastianbergmann/phpunit/issues/3370)

        Attachments

          Activity

            People

            Assignee:
            jaked Jake Dallimore
            Reporter:
            jaked Jake Dallimore
            Peer reviewer:
            Jun Pataleta Jun Pataleta
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            CiBoT CiBoT
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 5 minutes
                1h 5m