Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65324

Discussion list incorrectly reports visibility

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Unit test provided.

      Prerequisites:

      1. A course with a forum activity
      2. A teacher and student enrolled into the course
      3. 2 browsers (or 1 incognito)

      Instructions

      Case 1

      1. As a teacher in browser 1 create a new discussion with the following:
        1. DisplayPeriod end date - some date time in the future
      2. Confirm on the discussion list page, a calendar icon appears on the row corresponding to the discussion created.
      3. Confirm on hover of the calendar icon, it correctly reports the end date set in #1.1 AND that the discussion is visible to all students
      4. As a student in browser 2 go to the course and forum activity
      5. Confirm you can see the discussion

      Case 2

      1. As a teacher in browser 1 create a new discussion with the following:
        1. DisplayPeriod end date - some date time in the past
      2. Confirm on the discussion list page, a calendar icon appears on the row corresponding to the discussion created.
      3. Confirm on hover of the calendar icon, it correctly reports the end date set in #1.1 AND that the discussion is not visible to all students
      4. Confirm the row appears disabled.
      5. As a student in browser 2 go to the course and forum activity
      6. Confirm you cannot see the discussion
      Show
      Unit test provided. Prerequisites: A course with a forum activity A teacher and student enrolled into the course 2 browsers (or 1 incognito) Instructions Case 1 As a teacher in browser 1 create a new discussion with the following: DisplayPeriod end date - some date time in the future Confirm on the discussion list page, a calendar icon appears on the row corresponding to the discussion created. Confirm on hover of the calendar icon, it correctly reports the end date set in #1.1 AND that the discussion is visible to all students As a student in browser 2 go to the course and forum activity Confirm you can see the discussion Case 2 As a teacher in browser 1 create a new discussion with the following: DisplayPeriod end date - some date time in the past Confirm on the discussion list page, a calendar icon appears on the row corresponding to the discussion created. Confirm on hover of the calendar icon, it correctly reports the end date set in #1.1 AND that the discussion is not visible to all students Confirm the row appears disabled. As a student in browser 2 go to the course and forum activity Confirm you cannot see the discussion
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65324-master
    • Pull Master Diff URL:

      Description

      As an admin if you enable the display period(particularly with an end_date), it correctly reports it's visibility on the discussion list.

      Steps to reproduce;

      1. log in as admin
      2. Create a course, forum and a discussioin
      3. In the discussion, enable the end date to something in the future / past
      4. Navigate back to the discussion list and hover over the calendar icon and notice the descriptions are incorrect.

      NOTE: there are currently no tests to cover this situation. This is a regression from the forum rework

        Attachments

          Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-64820 Update forum display to use templates

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              peterdias Peter Dias
              Peer reviewer:
              Amaia Anabitarte Amaia Anabitarte
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 15 minutes
                  4h 15m