Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65344

Messaging: remove/deprecate get_individual_conversations_between_users()

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.8
    • Component/s: Messages
    • Labels:

      Description

      This method was created without having a need for it. It's only called by get_conversation_between_users() in the singular form, and in some unit tests and is not easy to read / maintain.

      Considering the above two methods, what we want is as follows:

      • Remove get_individual_conversations_between_users() [deprecate sadly, as it's public]
      • Rewrite get_conversation_between_users() to just make a DB call based on the type and conversation hash.
      • Adjust unit tests to use the rewritten method.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 21 minutes
                  2h 21m