Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65354

Incorrect context and name of capability moodle/course:browse

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin.
      2. Go to Site administration > Users > Permissions > Capability overview
      3. Search for moodle/course:browse
      4. Make sure it does not find that capability.
      5. Now, search for moodle/category:viewcourselist and set the roles field to All.
      6. Make that new capability exists and it is ALLOWED to: Authenticated user and Guest

      There shouldn't be any behat and PHP Unit failures.

      Show
      Log in as admin. Go to Site administration > Users > Permissions > Capability overview Search for moodle/course:browse Make sure it does not find that capability. Now, search for moodle/category:viewcourselist and set the roles field to All . Make that new capability exists and it is ALLOWED to: Authenticated user and Guest There shouldn't be any behat and PHP Unit failures.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65354-master
    • Pull Master Diff URL:

      Description

      As Eloy Lafuente (stronk7) pointed out in https://tracker.moodle.org/browse/MDL-10965?focusedCommentId=666186&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-666186

      the definition capability moodle/course:browse has incorrect context (should be category) and could be renamed to better indicate what it does.

        Attachments

          Issue Links

          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-55580 Process for deprecating a capability

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          New Feature - A new Moodle feature which has yet to be developed. MDL-10965 Add new capability to view the list of non-hidden courses

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Mihail Geshoski Mihail Geshoski
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 35 minutes
                  5h 35m