Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65382

Status labels in environment checks are all shown in grey

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Note: The status labels' actual font and background colours might be different from Bootstrap's defaults. The important thing is that they seem consistent with each other (e.g. badge-success is greenish, badge-info is blueish, badge-danger is reddish, etc.)

      Upgrade pages
      1. Do a web upgrade of your Moodle instance.
      2. On the Current release information page, check the Status column under the Server checks and Other checks section.
      3. Confirm that status texts are rendered consistently with Boostrap 4 badges.
      4. Press Continue
      5. On the Plugins check page, check the Source / Status column of the Plugins requiring attention table.
      6. Confirm that source and status texts are rendered consistently with Boostrap 4 badges. (The texts might be white in the BS4 page and black on the Moodle instance, but this will be fixed on a separate issue)
      Data privacy
      1. Create a data request either as a privacy officer/admin or as a user (just make sure that the config "Contact the privacy officer" is enabled).
      2. Check the status of the data request that was created.
      3. Confirm that status texts are rendered consistently with Boostrap 4 badges.
      LTI (You'll have to expose your server to an LTI provider, e.g. via ngrok)
      1. Go to Site administration / Plugins / Activities / External tool / Manage tools.
      2. Add this sample tool provider URL: https://lti.tools/test/tp.php
      3. Proceed with the setup.
      4. After the setup, check the tool card that was created under the Tools section.
      5. Check the status.
      6. Confirm that status label is rendered consistently with Boostrap 4 badges.
      Show
      Note: The status labels' actual font and background colours might be different from Bootstrap's defaults. The important thing is that they seem consistent with each other (e.g. badge-success is greenish, badge-info is blueish, badge-danger is reddish, etc.) Upgrade pages Do a web upgrade of your Moodle instance. On the Current release information page, check the Status column under the Server checks and Other checks section. Confirm that status texts are rendered consistently with Boostrap 4 badges . Press Continue On the Plugins check page, check the Source / Status column of the Plugins requiring attention table. Confirm that source and status texts are rendered consistently with Boostrap 4 badges . (The texts might be white in the BS4 page and black on the Moodle instance, but this will be fixed on a separate issue) Data privacy Create a data request either as a privacy officer/admin or as a user (just make sure that the config "Contact the privacy officer" is enabled). Check the status of the data request that was created. Confirm that status texts are rendered consistently with Boostrap 4 badges . LTI (You'll have to expose your server to an LTI provider, e.g. via ngrok) Go to Site administration / Plugins / Activities / External tool / Manage tools. Add this sample tool provider URL: https://lti.tools/test/tp.php Proceed with the setup. After the setup, check the tool card that was created under the Tools section. Check the status. Confirm that status label is rendered consistently with Boostrap 4 badges .
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-65382-master

      Description

      This seems to be because their styles are like "label badge-*" and .label doesn't work anymore since Bootstrapbase was removed. They should be "badge badge-*" instead.

        Attachments

        1. MDL-65382.jpg
          MDL-65382.jpg
          45 kB
        2. with-patch-1.png
          with-patch-1.png
          56 kB
        3. with-patch-2.png
          with-patch-2.png
          26 kB

          Activity

            People

            • Assignee:
              jpataleta Jun Pataleta
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Mathew May
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                20/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m