Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65393

Edge case bug with $SESSION->recentsessionlocks growing unchecked when using $CFG->debugsessionlock

XMLWordPrintable

      There is an edge case bug with the new feature in MDL-64449

      The session history cleanup is looking for 'gaps' in the history, but if you constantly ping a url then it never creates gaps, and even though there may not actually be session lock overlaps it still keeps the history around which grows unbounded. 

       

      Solution is some combination of making the cleanup a little more strict. Some ideas:

      1) make the gap smaller, eg 1 second

      2) cull old history when the cumulated gaps > 1 second

      3) have a hard cutoff of maximum stored history, something like 50 urls

       

            ilyatregubov Ilya Tregubov
            brendanheywood Brendan Heywood
            Matt Porritt Matt Porritt
            Jun Pataleta Jun Pataleta
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours
                3h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.