Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65394

Improve forum rendering speed

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Forum
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Create a site with 2 users (ensure both users have profile images set)
      3. Create a course with a forum and discussion
      4. Enrol the 2 users in the course
      5. Enable portfolios on the site (Site administration > advanced features > enable portfolios)
      6. Enable and make visible the file download portolio plugin (site administration > plugins > portfolio > manage porfolios)
      7. Log in as user 1 and post in the discussion and add a text file as an attachment to the post
      8. Log in as user 2 and post the following text in the discussion:
        • When $a \ne 0$, there are two solutions to (ax^2 + bx + c = 0) and they are $$x = {-b \pm \sqrt {b^2-4ac}

          \over 2a}.$$

      9. Log in as admin
      10. View the discussion
      11. CONFIRM that the posts have the author's profile image rendered
      12. CONFIRM that you can export the attachment posted by user 1 (click the plus icon next to the attachment) and/or the post
      13. CONFIRM that the post from user 2 has had the mathjax text filtered to show the equations (easiest way to confirm this would be to post the same text in a different Moodle install forum without these changes and confirm that it looks the same)
      Show
      Log in as admin Create a site with 2 users (ensure both users have profile images set) Create a course with a forum and discussion Enrol the 2 users in the course Enable portfolios on the site (Site administration > advanced features > enable portfolios) Enable and make visible the file download portolio plugin (site administration > plugins > portfolio > manage porfolios) Log in as user 1 and post in the discussion and add a text file as an attachment to the post Log in as user 2 and post the following text in the discussion: When $a \ne 0$, there are two solutions to (ax^2 + bx + c = 0) and they are $$x = {-b \pm \sqrt {b^2-4ac} \over 2a}.$$ Log in as admin View the discussion CONFIRM that the posts have the author's profile image rendered CONFIRM that you can export the attachment posted by user 1 (click the plus icon next to the attachment) and/or the post CONFIRM that the post from user 2 has had the mathjax text filtered to show the equations (easiest way to confirm this would be to post the same text in a different Moodle install forum without these changes and confirm that it looks the same)
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-65394-master

      Description

      Improve the rendering speed of the new forum rendering. At the moment it's marginally faster than the old rendering but there should be some things we can improve.

        Attachments

        1. perf_code_with_unread.png
          perf_code_with_unread.png
          157 kB
        2. perf_code_rating_disabled.png
          perf_code_rating_disabled.png
          157 kB
        3. perf_code_portfolio_enabled.png
          perf_code_portfolio_enabled.png
          155 kB
        4. perf_code_no_unread.png
          perf_code_no_unread.png
          158 kB
        5. old_code_with_unread.png
          old_code_with_unread.png
          160 kB
        6. old_code_rating_disabled.png
          old_code_rating_disabled.png
          158 kB
        7. old_code_portfolio_enabled.png
          old_code_portfolio_enabled.png
          154 kB
        8. old_code_no_unread.png
          old_code_no_unread.png
          159 kB
        9. new_code_with_unread.png
          new_code_with_unread.png
          159 kB
        10. new_code_rating_disabled.png
          new_code_rating_disabled.png
          159 kB
        11. new_code_portfolio_enabled.png
          new_code_portfolio_enabled.png
          158 kB
        12. new_code_no_unread.png
          new_code_no_unread.png
          159 kB
        13. MDL-65394.jpg
          MDL-65394.jpg
          32 kB
        14. generate_discussion_content.php
          8 kB

          Issue Links

            Activity

              People

              • Assignee:
                ryanwyllie Ryan Wyllie
                Reporter:
                ryanwyllie Ryan Wyllie
                Peer reviewer:
                Mathew May
                Integrator:
                Andrew Nicols
                Tester:
                Anna Carissa Sadia
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 31 minutes
                  1w 31m