Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65409

Google Drive Converter Upload response header now spells "location" instead of "Location"

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.6, 3.6.3
    • Fix Version/s: 3.6.6, 3.7.2
    • Component/s: Assignment
    • Labels:

      Description

      We encounter this issue on 4/23, when the google drive converter on our site decided to output blank document. 

      After rounds of debug, I found out that when start_document_conversion method in files/converter/googledrive/classes/converter.php uploads the document to google drive, and reads the response header to look for the location of the document download link, it tries to match "Location". 

      But somehow google is now responding with "location", causing the method can't find the download link and marks the conversion failed.

      The solution for us is just change Line 127 of files/converter/googledrive/classes/converter.php so it match "location" instead of "Location". I guess one can also just match it lowercase to ensure it work both way. 

       

      I am not certain if this is a one off case for our account.. it is strange for api to change response this way. But just want to point this out to help others with the same issue. 

       

        Attachments

          Activity

            People

            Assignee:
            damyon Damyon Wiese
            Reporter:
            moejarv Moe
            Peer reviewer:
            Mihail Geshoski
            Integrator:
            Andrew Nicols
            Tester:
            Víctor Déniz Falcón
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Sep/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 10 minutes
                3h 10m