Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65436

Undefined $select variable when upgrading

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      A. Create a new Moodle 3.4.x site

      1. Login as admin.
      2. Check that "Enable messaging system (messaging)" is enabled.
      3. Create 1 user (admin2).
      4. Access to "Site administration > Users > Permissions > Site administrators" and add "admin2" as admin.
      5. Login as admin2.
      6. From "Site administration > Users > Accounts > Bulk user actions", add admin and admin2 to the selection, choose "Send a message", write any text on the message body (for instance "This is a bulk message sent by the ADMIN2"), click over the "Save changes" button and confirm you want to send the message to all these users.
      7. Logout.

      Testing scenario: upgrade to master

      1. Upgrade the code from 3.4. to master.
      2. Login as admin and follow the upgrading steps.
      3. CHECK no error is displayed during the upgrade.
      4. Open your favourite database client (for instance, adminer) and access to the database where this Moodle instance is installed (for instance, integration_master).
      5. CHECK the table mdl_message_read is empty.
      Show
      A. Create a new Moodle 3.4.x site Login as admin. Check that "Enable messaging system (messaging)" is enabled. Create 1 user (admin2). Access to "Site administration > Users > Permissions > Site administrators" and add "admin2" as admin. Login as admin2. From "Site administration > Users > Accounts > Bulk user actions", add admin and admin2 to the selection, choose "Send a message", write any text on the message body (for instance " This is a bulk message sent by the ADMIN2 "), click over the "Save changes" button and confirm you want to send the message to all these users. Logout. Testing scenario: upgrade to master Upgrade the code from 3.4. to master. Login as admin and follow the upgrading steps. CHECK no error is displayed during the upgrade. Open your favourite database client (for instance, adminer) and access to the database where this Moodle instance is installed (for instance, integration_master). CHECK the table mdl_message_read is empty.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65436-master

      Description

      Got this error while upgrading to the latest weekly release:

      Notice: Undefined variable: select in /home/jun/moodles/stable_master/moodle/lib/db/upgrade.php on line 3135
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 35 minutes
                  2h 35m