[MDL-65468] DB error when using in-page discussion creation to create a discussion with subject, and no message - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.7
Fix Version/s: 3.7
Component/s: Forum
Labels:
- ci

Affected Branches:
MOODLE_37_STABLE
Fixed Branches:
MOODLE_37_STABLE
Epic Link:
Forum facelift
Pull from Repository:
git://github.com/mihailges/moodle.git
Pull Master Branch:
~~MDL-65468~~-master
Pull Master Diff URL:
https://github.com/mihailges/moodle/compare/09cbe51999...MDL-65468-master
Testing Instructions:
Hide

Log in as Admin.

Create a Course.

Create a Forum activity in the forum.

Attempt to create a discussion from the inline discussion creation form.

Enter a subject

Leave the message empty

Click "Post to forum"

make sure you do not see any DB errors

make sure you see a form warning that the Message is a required field. (NOTE: you will be redirected to the advanced discussion form)

Attempt to create a discussion from the advanced discussion creation form.

Enter a subject

Leave the message empty

Click "Post to forum"

make sure you do not see any DB errors

make sure you see a form warning that the Message is a required field
Show
Log in as Admin. Create a Course. Create a Forum activity in the forum. Attempt to create a discussion from the inline discussion creation form. Enter a subject Leave the message empty Click "Post to forum" make sure you do not see any DB errors make sure you see a form warning that the Message is a required field. (NOTE: you will be redirected to the advanced discussion form) Attempt to create a discussion from the advanced discussion creation form. Enter a subject Leave the message empty Click "Post to forum" make sure you do not see any DB errors make sure you see a form warning that the Message is a required field

Description

Given I open a forum
And I click "Create a new discussion topic"
And I set the "Subject" to "Example"
And I do not fill the "Message" field
When I click on "Post to forum"
Then I should see a form warning that the Message is a required field

But I see a DB error

Debug info: ERROR: null value in column "subject" violates not-null constraint

DETAIL: Failing row contains (31, 0, 0, 2, 1556764614, 1556764614, 0, null, , null, 0, , 0, 0, 0, 0).

INSERT INTO mdl_forum_posts (discussion,parent,privatereplyto,userid,created,modified,mailed,subject,message,messageformat,messagetrust,mailnow) VALUES($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12) RETURNING id

[array (

'discussion' => 0,

'parent' => 0,

'privatereplyto' => 0,

'userid' => '2',

'created' => 1556764614,

'modified' => 1556764614,

'mailed' => 0,

'subject' => NULL,

'message' => '',

'messageformat' => NULL,

'messagetrust' => 0,

'mailnow' => 0,

)]

Error code: dmlwriteexception

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-65468.jpg
27 kB
03/May/19 4:04 PM

Activity

People

Assignee:: Mihail Geshoski

Reporter:: Andrew Lyons

Peer reviewer:: Peter Dias

Integrator:: Jun Pataleta

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Jun Pataleta, Mihail Geshoski, Peter Dias

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 02/May/19 10:37 AM

Updated:: 04/May/19 1:29 AM

Resolved:: 04/May/19 1:29 AM

Fix Release Date:: 20/May/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 35m