Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65474

User image disappears when adding a video to a posting

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Create 2 moodle sites, one based on Moodle 3.6 (the old rendering) and one on master (with this patch applied)
      2. Set up each site the same way, as follows.
      3. Log in as admin
      4. Create another user and a course
      5. Enrol the user in the course
      6. Create a course group and add an image to the group
      7. Add the user to this group
      8. Create a forum and enable word counts and ratings
      9. Create a discussion
      10. View the discussion and add a reply
      11. Log in as the other user
      12. View the discussion
      13. Add a reply and make sure the reply contains the following:
        1. Some text
        2. Insert a video
        3. Insert an image
        4. Add an image as an attachment
        5. Add multiple non-image files as attachments

      Test

      1. Please test in all supported browsers
      2. Log in as admin in each of the sites
      3. View the discussion
      4. CONFIRM that the author profile images are visible in all posts
      5. CONFIRM that the group image is visible in the posts for the other user
      6. CONFIRM that the rating section appears in the same row as the post actions (reply, edit, delete etc)
      7. CONFIRM that the posts look pretty much the same between the new site and the old 3.6. Minor differences such as padding, profile image sizes, etc aren't a big deal.
      Show
      Setup Create 2 moodle sites, one based on Moodle 3.6 (the old rendering) and one on master (with this patch applied) Set up each site the same way, as follows. Log in as admin Create another user and a course Enrol the user in the course Create a course group and add an image to the group Add the user to this group Create a forum and enable word counts and ratings Create a discussion View the discussion and add a reply Log in as the other user View the discussion Add a reply and make sure the reply contains the following: Some text Insert a video Insert an image Add an image as an attachment Add multiple non-image files as attachments Test Please test in all supported browsers Log in as admin in each of the sites View the discussion CONFIRM that the author profile images are visible in all posts CONFIRM that the group image is visible in the posts for the other user CONFIRM that the rating section appears in the same row as the post actions (reply, edit, delete etc) CONFIRM that the posts look pretty much the same between the new site and the old 3.6. Minor differences such as padding, profile image sizes, etc aren't a big deal.
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-65474-master

      Description

      The left column containing user + group images collapses when adding a video to a posting.

      additional points I'll address in this issue:
      The user + group images are not part of the post header but shown as a column left of the post. Which makes the post heading hard to style using css.

      There is no visual distinction between user and group images.

      The user image has a aria-hidden=true tag, the group images don't have the aria-hidden tag.

      When adding a rating to forum posts the rating selector position looks wrong, it should be part of the post footer.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 15 minutes
                  4h 15m