Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65484

The comment and annotations are displayed outside the boundaries of the view annotated PDF window for an assignment

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Pre-requisites

      1. Make sure that a document converter is installed and working on your site (i.e. Unoconv)

      Setup

      1. Create a course with a teacher enrolled in it with the "editing teacher" role and a student enrolled with the student role. 

      Test

      1. Log in as the teacher and create an assignment with online text submissions and "Annotate PDF" feedback enabled.
      2. From the "View all submissions" page for the assignment, edit the students submission to add at least 2 pages of text.
      3. As a teacher, grade the submission and add one of each of these annotations to the top of each submission page.
        1. Text comment
        2. Squiggly line
        3. Straight line
        4. Rectangle
        5. Circle
        6. Highlighter box
        7. Stamp
      4. Return to the "View all submissions" page for the assignment
      5. Click on the "View the Annotated PDF..." link for the submission.
      6. Visit each page of the annotated PDF and scroll the document down.
      7. On each page, verify none of the annotations are displayed outside of the scrollable region for the feedback document (see the screenshot image on this issue for an example of a fail).

       

      Show
      Pre-requisites Make sure that a document converter is installed and working on your site (i.e. Unoconv) Setup Create a course with a teacher enrolled in it with the "editing teacher" role and a student enrolled with the student role.  Test Log in as the teacher and create an assignment with online text submissions and "Annotate PDF" feedback enabled. From the "View all submissions" page for the assignment, edit the students submission to add at least 2 pages of text. As a teacher, grade the submission and add one of each of these annotations to the top of each submission page. Text comment Squiggly line Straight line Rectangle Circle Highlighter box Stamp Return to the "View all submissions" page for the assignment Click on the "View the Annotated PDF..." link for the submission. Visit each page of the annotated PDF and scroll the document down. On each page, verify none of the annotations are displayed outside of the scrollable region for the feedback document (see the screenshot image on this issue for an example of a fail).  
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-65484-master

      Description

      Steps to reproduce:

      1. Log in as a teacher and create an assignment with file submissions enabled.
      2. As a student, submit a multi-page file (of a format that can be converted to PDF).
      3. As a teacher, annotate the submission with several comments on different pages.
      4. Add a few annotations of other types and save the changes.
      5. Release the feedback.
      6. Log in as a student and view the annotated PDF using the online viewer.

       

      Expected:

      • when scrolling on the annotated PDF viewer the comments/annotations should not be displayed outside the viewer boundaries

      Actual:

      • comments and annotations display out the boundaries of the viewer when scrolling (see screenshot example attached)

       

       

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 40 minutes
                  4h 40m