Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65499

Bug introduced in phpunit 7.5.7 leads to errors on failures

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.7
    • 3.7
    • Unit tests
    • MOODLE_37_STABLE
    • MOODLE_37_STABLE
    • Hide

      Basically regression testing.

      • Verify that phpunit is now being used vendor/bin/phpunit --version. After compose install or in CI runs.
      • Verify that both travis and CI runs (phpunit & behat) continue running (and passing, punctual failures aside) ok.

      Ciao

      Show
      Basically regression testing. Verify that phpunit is now being used vendor/bin/phpunit --version . After compose install or in CI runs. Verify that both travis and CI runs (phpunit & behat) continue running (and passing, punctual failures aside) ok. Ciao

    Description

      While running phpunit under windows, it was detected that, when a failure (like MDL-65498) happens... the phpunit execution ends with bad errors, instead of continuing ok.

      After searching for causes we found https://github.com/sebastianbergmann/phpunit/issues/3564 that seems to be the cause for failed tests causing the problem.

      The issue above was fixed for phpunit 7.5.8. Right now the latest version is phpunit 75.9.

      This issue is about to update phpunit to that version folowing the instructions to do it and verify that everything continues working ok.

      Ciao

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Simey Lameze Simey Lameze
              Andrew Lyons Andrew Lyons
              CiBoT CiBoT
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                20/May/19

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m