Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6550

Bug allowing limits on choice to be by-passed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.4, 1.7
    • Component/s: Choice
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE

      Description

      When a limit is applied to a choice if a collection of users have the choice form open and the limit has not been breached,
      these users will all be able to submit their choice and effectivly by-pass the limit controls.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            gbyrne Graeme Byrne added a comment -

            file patch for /mod/choice/lib.php

            266,268c266,269
            <
            < $countanswers = count($countans);
            < } else

            { --- > //@EC GB Limit fix > $countanswers =$countans; > > }

            else {

            Show
            gbyrne Graeme Byrne added a comment - file patch for /mod/choice/lib.php 266,268c266,269 < < $countanswers = count($countans); < } else { --- > //@EC GB Limit fix > $countanswers =$countans; > > } else {
            Hide
            gbyrne Graeme Byrne added a comment -

            see attached files for suggested fix

            Show
            gbyrne Graeme Byrne added a comment - see attached files for suggested fix
            Hide
            danmarsden Dan Marsden added a comment -

            Thanks Graeme - Sorry for the delay - we've got a new addition to the whanau and our house recently went through a big rennovation, so I've been offline for a couple of weeks! - will try to test/patch this tomorrow!

            thanks!


            Dan

            Show
            danmarsden Dan Marsden added a comment - Thanks Graeme - Sorry for the delay - we've got a new addition to the whanau and our house recently went through a big rennovation, so I've been offline for a couple of weeks! - will try to test/patch this tomorrow! thanks! Dan
            Hide
            danmarsden Dan Marsden added a comment -

            Fixed - now in 1.6Stable, 1.7Stable and HEAD - may take a while to get updated - sorry for the delay - I'm only starting to get back on board now! - got 7 hours sleep last night! - woohoo!

            Show
            danmarsden Dan Marsden added a comment - Fixed - now in 1.6Stable, 1.7Stable and HEAD - may take a while to get updated - sorry for the delay - I'm only starting to get back on board now! - got 7 hours sleep last night! - woohoo!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  7/Nov/06