Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65515

Badges upgrade step should not require lib/badgeslib.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7, 3.8
    • Fix Version/s: 3.7.3
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide

      Verifying upgrade.

      1. Install MOODLE_36_STABLE
      2. Upgrade to MOODLE_37_STABLE

        git checkout MOODLE_37_STABLE && php admin/cli/upgrade.php

      3. Verify there are no errors generated during upgrade.
      4. Repeat steps 2 & 3, bust upgrading to master.

      Verifying install.

      1. Install MOODLE_37_STABLE
      2. Verify there are no errors generated during install.
      3. Repeat steps 1 & 2, bust installing master.
      Show
      Verifying upgrade. Install MOODLE_36_STABLE Upgrade to MOODLE_37_STABLE git checkout MOODLE_37_STABLE && php admin/cli/upgrade.php Verify there are no errors generated during upgrade. Repeat steps 2 & 3, bust upgrading to master. Verifying install. Install MOODLE_37_STABLE Verify there are no errors generated during install. Repeat steps 1 & 2, bust installing master.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull 3.7 Branch:
    • Pull Master Branch:
      MDL-65515-master

      Description

      The one function that is required for new installs and upgrades is badges_install_default_backpacks() which creates the backpacks:

      This function does not do any custom logic, it just makes DB queries to insert the backpacks using constants. Those constants and the function should be split into a separate location so they can be called during install/upgrade without loading the rest of the badges functions / constants.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Mihail Geshoski
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 30 minutes
                  3h 30m