Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65516

Transition missing when opening quick reply

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as Admin.
      2. Create a Course.
      3. Create a Forum in the Course.

      Test 1.

      1. Use the inline discussion form to create a discussion.
        • before creating the discussion, toggle (display/hide) the form by clicking on the "Add new discussion topic" button.
          • notice the slide transition when showing/hiding the form
      2. After creating the discussion, go to the Discussion.
      3. Attempt to leave a reply in the Discussion.
        • toggle (display/hide) the inline reply form by clicking on the "Reply" link
          • make sure there is a sliding transition when showing/hiding the inline reply form

      Test 2.

      1. Create a Discussion with multiple replies.
      2. Create a reply (test reply).
        • notice the hash added to the url (#p??), that points to the reply's content
        • the page should scroll and point the to added reply (test reply).
      3. Reload the current page (with the included hash)
      4. Click on the 'Reply' button of one of the older replies.
        • make sure the inline reply form for the particular post is opened. 
        • make sure the page does not scroll (points) to the previously added reply (test reply)
      Show
      Login as Admin. Create a Course. Create a Forum in the Course. Test 1. Use the inline discussion form to create a discussion. before creating the discussion, toggle (display/hide) the form by clicking on the "Add new discussion topic" button. notice the slide transition when showing/hiding the form After creating the discussion, go to the Discussion. Attempt to leave a reply in the Discussion. toggle (display/hide) the inline reply form by clicking on the "Reply" link make sure there is a sliding transition when showing/hiding the inline reply form Test 2. Create a Discussion with multiple replies. Create a reply (test reply). notice the hash added to the url (#p??), that points to the reply's content the page should scroll and point the to added reply (test reply). Reload the current page (with the included hash) Click on the 'Reply' button of one of the older replies. make sure the inline reply form for the particular post is opened.   make sure the page does not scroll (points) to the previously added reply (test reply)
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-65516-master
    • Pull Master Diff URL:

      Description

      The quick discussion create transitions the editor open
      The quick reply does not, leading to a bit of a jarring experience.

      Videos attached.

      Also, it would be nice if we could fix in one go the unnecessary scrolling to the most recently added post (when there is a hash in the url pointing to the reply), when clicking on an unrelated 'Reply' link.

      Steps to reproduce this:

      1. Create a course.
      2. Create a forum.
      3. Create a Discussion with multiple replies.
      4. Create a reply (test reply).
        • a hash should be added to the url and the page should scroll and point the to added reply (test reply).
      1. Reload the current page (with the included hash)
      2. Click on the 'Reply' button of one of the older replies.
        1. expected: the inline reply form for the particular post is opened and the page scroll STAYS STATIC.**
        2. actual : the inline reply form for the particular post is opened but the page scroll moves and focuses on the previously added reply (test reply)

        Attachments

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Simey Lameze
            Integrator:
            Adrian Greeve
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              20/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 55 minutes
                2h 55m