-
Bug
-
Resolution: Fixed
-
Critical
-
3.7
-
MOODLE_37_STABLE
-
MOODLE_37_STABLE
-
MDL-65536-master -
This is a followup of MDL-62599 where any detected and remaining issues should be fixed before Moodle 3.7 release (20th May 2019).
With the code already available upstream we should be able to advance here at good pace.
Specifically, let's pay attention to the results gathered from the testing session started in the original issue.
Ciao
Specifically, the items which need to be resolved ASAP:
1. No connectivity whatsoever to the LTI 1.3 test suite on a fresh install - OIDC error invalid request when opening the tool. A site upgrading from 3.6 worked, so I suspect something was missed in the install code. EDIT: See the cause in my comment below.
2. Windows install with improperly configured openssl. The code:
$res = openssl_pkey_new($config);
|
openssl_pkey_export($res, $privatekey);
|
will result in $res being false, and then a warning will be thrown for the second line as 'false' isn't valid for $res. Configuring fixes this, but given we don't detect this, we'll end up with a missing private key and broken 1.3 support. This code is run during upgrade and install. We discussed disabling the module if the configuration is known to be in error, but the specifics are yet to be determined on this. I welcome any input.
3. Testing errors (from LTI 1.1 and LTI 2 external test suites), as reported on MDL-62599. Need to test 3.6 and see whether these same failures were present. If so, disregard.
4. Firebase\JWT\JWT should be class autoloadable and not be required.
- caused a regression
-
MDL-65610 Undefined index warning editing LTI preconfigured tool
- Closed
- Discovered while testing
-
MDL-62599 Add LTI 1.3 support to Moodle
- Closed
- has a non-specific relationship to
-
MDL-13503 Moodle Networking: cannot find openssl.cnf so networking fails.
- Closed
- has been marked as being related by
-
MDL-74604 Private key check missing from dynamic registration workflow
- Open
- Testing discovered
-
CONTRIB-7716 BBB incluses Firebase\JWT which conflicts with the version in core
- Resolved