Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65574

Forum render breaks when viewing split discussion with missing author

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7
    • Fix Version/s: 3.7
    • Component/s: Forum
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Create course with 2 standard forums
      3. Create 2 users and enrol them as students in the course
      4. Create a discussion in one of the forums
      5. Log in as one of the users
      6. View the discussion and add a reply
      7. Log in as the other user
      8. View the discussion and add a reply to the previous user's reply (not the original post)
      9. Log back in as admin
      10. View the discussion
      11. Split the post at the first user's reply
      12. After the split has created the new discussion move that discussion into the other forum
      13. View the first forum
      14. CONFIRM that it shows the original discussion
      15. CONFIRM the author in the "started by" column is the admin user
      16. CONFIRM the author in the "last post" column is the admin user
      17. View the second forum
      18. CONFIRM that it shows the newly created discussion from the split
      19. CONFIRM the author in the "started by" column is the first user
      20. CONFIRM the author in the "last post" column is the second user
      Show
      Log in as admin Create course with 2 standard forums Create 2 users and enrol them as students in the course Create a discussion in one of the forums Log in as one of the users View the discussion and add a reply Log in as the other user View the discussion and add a reply to the previous user's reply (not the original post) Log back in as admin View the discussion Split the post at the first user's reply After the split has created the new discussion move that discussion into the other forum View the first forum CONFIRM that it shows the original discussion CONFIRM the author in the "started by" column is the admin user CONFIRM the author in the "last post" column is the admin user View the second forum CONFIRM that it shows the newly created discussion from the split CONFIRM the author in the "started by" column is the first user CONFIRM the author in the "last post" column is the second user
    • Affected Branches:
      MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-65574-master

      Description

      Due to MDL-65573 we can have discussion records who's "userid" values don't match any the discussion's post's authors.

      This mismatch causes the new rendering to break because it assumes that the "userid" field will always refer to an author of a post within the discussion.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ryanwyllie Ryan Wyllie
                Reporter:
                ryanwyllie Ryan Wyllie
                Peer reviewer:
                Simey Lameze
                Integrator:
                Andrew Nicols
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 6 minutes
                  5h 6m