Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-65581

Hidden blocks can not be unhidden

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.5.6, 3.6.4, 3.7
    • Fix Version/s: 3.5.7, 3.6.5
    • Component/s: Themes
    • Testing Instructions:
      Hide

      Testing in Moodle 3.7:

      Moodle 3.7,  theme Boost

      • Login as any user
      • Navigate to your dashboard
      • Click the "Customise this page" button
      • Click the "Add a block" button
      • Choose a block, for example the Tags block
      • On the newly added block click the gear icon in the top right
      • Click hide block
      • Verify the block content is completely hidden, the block should still be visible
      • Verify the block heading text is a lighter grey

      Moodle 3.7,  theme Classic

      • Login as any user
      • Navigate to your dashboard
      • Click the "Customise this page" button
      • Select a block from the "Add a block" Selector
      • Choose a block, for example the Tags block
      • On the newly added block click the gear icon in the top right
      • Click hide block
      • Verify the block content is completely hidden, the block should still be visible
      • Verify the block heading text is a lighter grey

      Moodle 3.6 and 3.5, Theme Clean

      • Login as any user
      • Navigate to your dashboard
      • Click the "Customise this page" button
      • Select a block from the "Add a block" Selector
      • Choose a block, for example the Tags block
      • On the newly added block click the gear icon in the top right
      • Click hide block
      • Verify the block content is completely hidden, the block should still be visible
      • Verify the block heading text is a lighter grey
      Show
      Testing in Moodle 3.7: Moodle 3.7,  theme Boost Login as any user Navigate to your dashboard Click the "Customise this page" button Click the "Add a block" button Choose a block, for example the Tags block On the newly added block click the gear icon in the top right Click hide block Verify  the block content is completely hidden, the block should still be visible Verify  the block heading text is a lighter grey Moodle 3.7,  theme Classic Login as any user Navigate to your dashboard Click the "Customise this page" button Select a block from the "Add a block" Selector Choose a block, for example the Tags block On the newly added block click the gear icon in the top right Click hide block Verify  the block content is completely hidden, the block should still be visible Verify  the block heading text is a lighter grey Moodle 3.6 and 3.5, Theme Clean Login as any user Navigate to your dashboard Click the "Customise this page" button Select a block from the "Add a block" Selector Choose a block, for example the Tags block On the newly added block click the gear icon in the top right Click hide block Verify  the block content is completely hidden, the block should still be visible Verify  the block heading text is a lighter grey
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.5 Diff URL:
    • Pull 3.6 Branch:
    • Pull 3.6 Diff URL:
    • Pull Master Branch:
      MDL-65581-master
    • Pull Master Diff URL:

      Description

      In MDL-58314 the block renderer was changed to allow custom css classes inserted in the block template.

      As a result, hidden blocks are using the 'invisible' class added in blocks/moodleblock.class.php

      In Bootstrap 4 the .invisible class completely hides an element.

      • To reproduce:
      • navigate to your dashboard
      • Click the customise this page button
      • Add a block (any type will do)
      • Click the gear icon on the new block
      • Observe the block disappearing. You will see an empty space where the block was added

        Attachments

          Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-58315 Boost theme ignores HTML block custom classes

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 21 minutes
                  5h 21m